Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEEDBACK] Change "All data returned from APIs must be JSON serializable." #8

Closed
lorddaedra opened this issue Apr 13, 2019 · 2 comments

Comments

@lorddaedra
Copy link

Sometimes in russian Telegram chats I read "Django was sexy in 2008-2012, but it looks legacy and outdated in 2019 now...". Thank you for share your opinion, I completely agree with your suggestions. This is the best way to answer them "No, Django is modern framework for modern web. And there is the Guide how to cook Django. How to make Django Great Again".

Okay...

About APIs. Check this project. https://github.com/gluk-w/django-grpc/tree/master/tests Author tried to implement gRPC server with django project. Also https://github.com/grpc/grpc-web is stable now... So in my opinion line "All data returned from APIs must be JSON serializable." is incorrect. It's depends on API types...

@phalt
Copy link
Owner

phalt commented Apr 16, 2019

@lorddaedra Hey Daedra, thanks for your feedback! I agree that the ruling All data returned from APIs must be JSON serializable doesn't accommodate gRPC. Let's look back at what my original goal was to help us figure out a better definition:

In order to reduce cross-domain dependency, I wanted to prevent Objects from one domain entering another, thus I wrote the ruling about JSON serializable. What about this as a better re-wording:

All data returned from APIs but be serializable

Or how about

APIs must never return rich objects from a domain

@phalt
Copy link
Owner

phalt commented Jun 10, 2019

Resolved with commit ea36acd

@phalt phalt closed this as completed Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants