Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affiliations #57

Open
euanwho opened this issue Aug 14, 2016 · 7 comments
Open

Affiliations #57

euanwho opened this issue Aug 14, 2016 · 7 comments

Comments

@euanwho
Copy link

euanwho commented Aug 14, 2016

I would be happy to work on faction details for People, eg Resistance, Rebels, Republic, Empire, First Order, etc.

@euanwho
Copy link
Author

euanwho commented Aug 14, 2016

Maybe Affiliation would be a better name for it. That is what Wookiepedia calls it.

@jhdoak
Copy link

jhdoak commented Aug 15, 2016

Might be good to put affiliations in an array to accommodate for those who have defected/changed affiliation at some point and would need multiple entries.

@euanwho
Copy link
Author

euanwho commented Aug 15, 2016

Sounds good. The affiliations that a person has defected from will have (formerly) afterwards.
The affiliations I am thinking of are these:

  • Separatist State
  • Jedi Order
  • Galactic Republic
  • Order of Sith Lords
  • Galactic Empire
  • New Republic
  • Rebel Alliance
  • First Order
  • Resistance
  • Hutt Clan
  • Luke Skywalker's Jedi

What do you think?

@jhdoak
Copy link

jhdoak commented Aug 15, 2016

Looks like a solid list! My only question with that is, how do we determine what affiliation is "current"? For example, a character from SWRebels could have one "current" affiliation in the show (and have an arc that hasn't resolved), but then could hypothetically show up in a future movie with another "current" affiliation. When you think about it, everything in SW happened "a long, long time ago", so it might be cleaner not to list any as formerly.

To me the solution depends on how in depth we want to get. The simple solution would be to just list all affiliations without indicating "formerly" or anything like that. A more complicated solution would be something along the lines of giving each affiliation a rough year range for when they held that affiliation, or associating their affiliation with major events (for example, Anakin could be listed as being affiliated with the Jedi order up through the clone wars).

Not sure what the best solution is, just some thoughts.

@euanwho
Copy link
Author

euanwho commented Aug 15, 2016

I think you are right. I was thinking of giving Han Solo an affiliation with Hutt Clan, then saying formerly. But I think that it might be clearer just to leave it off. I think that the complicated solution will be too complicated, I am willing to put the basic affiliations in and if someone wants to do that then they are welcome.

One question, how do I update models.py to show that Affiliations is an array. For instance, name is a string and it is written like this: name = models.CharField(max_length=100)

I am not sure how to do this.

@euanwho euanwho changed the title Faction Details Affiliations Aug 15, 2016
@jhdoak
Copy link

jhdoak commented Aug 15, 2016

Yeah I agree, going the simple route is probably best. As far as your question with models.py, I can't help ya there. Hopefully someone else chimes in.

@phalt
Copy link
Owner

phalt commented Aug 16, 2016

@jhdoak Use the date 0 ABY (After the Battle of Yavin, or the episode 4) for the "currentness".

@euanwho You want to make a relationship between a character and a new model called affiliation. The character should have a foreign key to affiliation (because an affiliation can have many characters, but a character can only have one affiliation) See the Django documentation: https://docs.djangoproject.com/en/1.10/ref/models/fields/#foreignkey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants