Invalid VarError with usage of references

[Seldaek]

I got a minimal repro case for this:

<?php

class Test {
    protected $capture;

    function foo($command, &$bar = null) {
        $this->capture = count(func_get_args()) > 1;
        if ($this->capture && !is_callable($bar)) {
            $bar = 'bar';
        }
    }

    function foo2(&$bar) {}
}

(new Test)->foo('cmd', $undef);
var_dump($undef);

(new Test)->foo2($undef2);
var_dump($undef2);

Phan outputs:

test.php:17 VarError Variable $undef is not defined
test.php:20 VarError Variable $undef2 is not defined

However, php executes this just fine and outputs 'bar' & NULL. Passing the variables by reference defines them even if they are not assigned by the callee. get_defined_vars() also confirms that.

[Seldaek]

Cool thanks for the quick turnaround, I'll try to do another pass over the weekend and look at the less common errors to see if I find any other false positives :)

[morria]

That sounds great. Thanks!