Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHAR supported by project "Baseline for PHP CS Fixer" #157

Closed
Aeliot-Tm opened this issue Aug 31, 2024 · 9 comments
Closed

PHAR supported by project "Baseline for PHP CS Fixer" #157

Aeliot-Tm opened this issue Aug 31, 2024 · 9 comments

Comments

@Aeliot-Tm
Copy link
Contributor

Hi @theseer

I added support of PHAR to may repo. And signed it with GPG key.
What my next steps to make it accessible via Phive?

Link to release with PHAR: https://github.com/Aeliot-Tm/php-cs-fixer-baseline/releases/tag/v1.2.0

@Aeliot-Tm
Copy link
Contributor Author

image

@Aeliot-Tm
Copy link
Contributor Author

As I can see, the problem is in the difference of the vendor name of package and the username of repository where the package is hosted. How could I help for PHIVE installer to use proper repository?
image

@theseer
Copy link
Member

theseer commented Sep 4, 2024

Why not use aeliot-tm/php-cs-fixer-baseline?

@theseer
Copy link
Member

theseer commented Sep 4, 2024

For the record: Phive doesn't really care about composer / packagist naming as it's independent from it, it's just a convention adopted as people are familiar with it and of course because the pattern makes sense.

As can be seen in the URLs accessed in your example, when the passed argument is containing a single /, phive is considering it a namespace/project-name, trying github as well as gitlab using their respective formats.

A 3rd option is to register an alias with us, so people can use "php-cs-fixer-baseline" for instance, and phive would know where to get the files as they are pre-resolved: https://phar.io/distribute-your-own.html

@Aeliot-Tm
Copy link
Contributor Author

@theseer Thank you so much!

I'll provide alias for the project.

Did not see this instruction about distribution before. May be it would be nice to have some menu on the site for better navigation 😃

@theseer
Copy link
Member

theseer commented Sep 4, 2024

image

"Distribute your own" is on the main navigation :)

@Aeliot-Tm
Copy link
Contributor Author

OMG! It's my fait.
Thank you, again

@Aeliot-Tm
Copy link
Contributor Author

@theseer I created PR. Could you accept it?
#158

@theseer
Copy link
Member

theseer commented Sep 4, 2024

I consider this completed.

@theseer theseer closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants