Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with drag and drop #3679

Closed
hilaire opened this issue Jun 28, 2019 · 5 comments · Fixed by #3830
Closed

Regression with drag and drop #3679

hilaire opened this issue Jun 28, 2019 · 5 comments · Fixed by #3830

Comments

@hilaire
Copy link

hilaire commented Jun 28, 2019

PasteUpMorph>>dropFiles:

Looks wrong in P7 and P8.
A Write stream is created while a Read stream is expected.
Result: drag and drop of a sketch file does not work anymore in DrGeo.
Should it be a binary read stream or just a read stream?
With a read stream it works fine for DrGeo, not sure about other.

See #2634 too

PasteUpMorph-dropFiles.st.txt

@svenvc
Copy link
Contributor

svenvc commented Jun 28, 2019

This is indeed not such a simple situation, since it requires insight into the services framework, which is a bit quirky (from what I have seen of it). I certainly don't understand all aspect of it.

I think that the only sensible thing to do is to pass a FileReference object around, not an open stream, since after all, that is what you are dropping, and then leave to opening of the file to the latest possible moment.

@hilaire
Copy link
Author

hilaire commented Jun 29, 2019

In the meantime, could we reverse to a situation equivalent to the previous one?
=>A read stream is passed on to the drop event handlers

@svenvc
Copy link
Contributor

svenvc commented Jun 29, 2019

you said it has to respond to #name, which the new streams don't do and never will, hence my suggestion

@hilaire
Copy link
Author

hilaire commented Jun 29, 2019

Ah yes indeed.

@tomooda
Copy link
Contributor

tomooda commented Jul 8, 2019

+1 for passing a FileReference. I admit I have a same problem to read a dropped stream and hacked the stream object as a nasty workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants