[Backport]3437-Adding-an-instance-class-variable-remove-the-traits-of-a-class #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you need to look at fillFor:, too... it was missing setting something in Pharo8 |
|
Oh, ok. Just this already fix the problem we had, but maybe there is another one? |
|
ah, the fix there might have been a side effect of removing copyClassSlotsFromExistingClass... |
|
So, what would be the clean solution? Do you have an idea? |
This reverts commit 1d04cf1.
|
I reverted the change on fillFor: since it can cause problem. |
|
Faling tests are already failing for me in a clean image. |
|
So do we merge this? It is for Pharo7 |
|
@tesonep Is that Ok for you? |
|
So what do we do? |
|
If nobody objects, this will be merged end of the week. |
|
We can ask people to review during the sprint |
jecisc
deleted the
3437-Adding-an-instance-class-variable-remove-the-traits-of-a-class
branch
jecisc
restored the
3437-Adding-an-instance-class-variable-remove-the-traits-of-a-class
branch
|
Oups, I closed it by accident because I cleaned my branched and this one had more than 1 month. |
|
I finally merged it. |
jecisc
deleted the
3437-Adding-an-instance-class-variable-remove-the-traits-of-a-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport fix in class slot addition.
Fixes #3437