Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4837-Typing-Point-in-Transcript-raises-a-DNU-on-completion #4845

Conversation

@MarcusDenker
Copy link
Member

MarcusDenker commented Oct 7, 2019

fixes #4837

@Ducasse

This comment has been minimized.

Copy link
Member

Ducasse commented Oct 8, 2019

It would be nice to package this as extensions of the completion engine?

@MarcusDenker

This comment has been minimized.

Copy link
Member Author

MarcusDenker commented Oct 16, 2019

We need to clean this up. There is a huge mess in these methods: #selectedBehavior #selectedClass, #selectedClassOrMetaClass.

One of these is needed to evaluate, too. See #modelCurrentSelectedClass in the editor...

I propose to merge this as cleaning this up is another thing. (I put it on the backlog)

@MarcusDenker MarcusDenker merged commit ff90c49 into pharo-project:Pharo8.0 Oct 16, 2019
2 of 3 checks passed
2 of 3 checks passed
probot/minimum-reviews Pending review approvals
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.