[FeedbackNeeded] test color report (drTest/Calypso)

[hogoww]

Started to change colors used by DrTest and Calypso, to be less flashy.
Not ready, want to change some more stuff with Julien a bit later today.

commit number 3 is lacking a part of its message: 'and tweeked color to be less flashy'
overs are explicit

[hogoww]

SimpleButtonMorph >> doButtonAction was as far as I went to find Calypso's colors.
But I feel they are fine in comparison, being so small and without text, so i don't know if i'll investigate further.

[hogoww]

Ok, so now we have default color described in Sunit. gonna try to find "better" colors for tests.

@dionisiydk Didn't find the color for unit tests in Calypso yet. Could you give me an hint as where I should look please?

[hogoww]

Attempted to have better coloring for DrTest/Calypso test. Would love some feedback to be able to know what would be nicer.

Important note: Spec2 doesn't support coloring for buttons label's, so we're stuck with white text in dark mode for now.

[juliendelplanque]

Seems nice, little detail to discuss, see related comments.

[estebanlm]

1. I need a screenshot to evaluate the before/after of the changes
2. I like to remove hardcoded colours
3. This will be for Pharo9.0 now :)

[hogoww]

For the dark theme:
Personnal notes first:

• I cannot read anything on the current success/failure, error is okay.
• My screen is probably too bright, but on it some colors are just blinding. Got to hide my drtest under another window 1
• We added support for default font color, but Spec does not support it yet (soon !). Still, this prevents us to do better, by replacing the font color and have a nice color, with readable text.
  (also, my color vision is not the best..)

success new

success old

failure new

failure old

error new

error old

[hogoww]

light theme
Only failure was unusable.
I'm not sure why text is white and don't remember if I once knew.
This is making it worse though.
iirc the text color follows the theme (white text dark theme / black text white theme...)

Success new

success old

failure new

failure old

error new

error old

[Ducasse]

I usually cannot read comments in the black theme and the red is also far too strong I cannot read text in it.

[Ducasse]

So take care of it is really important.

[hogoww]

@Ducasse "I usually cannot read comments in the black" Alright, but this is unrelated to this PR, unless I misunderstood.
"the red is also far too strong I cannot read text in it." Do you mean the Dark theme new red ?

[Ducasse]

Julien we have a conflict.

[hogoww]

Should be fine now

[hogoww]

Failure seems unrelated :)