willCreateBlock-support-fullBlock #6765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in the debugger that temps are read from the wrong context
MarcusDenker
added
the
Status: Need more work
dionisiydk
reviewed
Jul 3, 2020
|
StepThroughTest>>testStepThrough fails after this. Which is interesting... and needs some analysis. |
MarcusDenker
removed
the
Status: Need more work
|
unix-64 / Tests-unix-64 / testStepOverAssignment – Unix64.Debugger.Tests.Base.AssignmentAndLiteralDebuggerTest unix-64 / Tests-unix-64 / testNewDebugSession – Unix64.Debugger.Tests.Base.AssignmentAndLiteralDebuggerTest unix-64 / Tests-unix-64 / testStepIntoAssignment – Unix64.Debugger.Tests.Base.AssignmentAndLiteralDebuggerTest |
MarcusDenker
added
the
Status: Need more work
- step only once in testStepIntoAssignment and testStepOverAssignment. Why did we step twice? - context of the block has size 2
MarcusDenker
added
Status: Tests passed please review!
and removed
Status: Need more work
pavel-krivanek
approved these changes
Jul 9, 2020
|
Marcus I integrate it and we will see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
willCreateBlock does not detect full blocks, this leads to to problems in the debugger that temps are read from the wrong context