You cannot *not* request an MDN

[kukel]

Version: AS2-LIB 4.1.1-SNAPSHOT from 'master'

In AS2Client in the buildPartnership the AS2MDNTo is always set, so an MDN is always requested. You cannot unset it or populate the partnership in a different way

aPartnership.setAS2MDNTo (aSettings.getSenderAS2ID ());

So it is effectively impossible to not request an MDN (Yes, I know it is strange but there is one case configured like that live with a customer (yes for a test system, but still)

If I comment out the line above in the code

Maybe an additional method where the partnership is explicitly passed on, not via the settings would be a good addition.

[kukel]

I don't think it is an enhancement but the result of the fix in #42 (9070fc2) which is effectively not fully correct and hence a 'bug' ;-)

[kukel]

There is a

@Nonnull
  public AS2ClientSettings setSenderData (@Nonnull final String sAS2ID,
                                          @Nonnull final String sEmailAddress,
                                          @Nonnull final String sKeyAlias)
  {

on the AS2ClientSettings, should the email address from that not be used instead of a fixed string in 71d92f3#diff-71c23868cad98a869a3e7fcd1c7dcef8R174

[phax]

You know my code better than me :)

[phax]

Did you check whether it works as expected?

[kukel]

Will test later today.

[kukel]

Seems to be working!

[phax]

Great - thanks for testing.