Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disposition-notification-to header #42

Closed
zharpaz-bmc-com opened this issue Jun 29, 2018 · 13 comments
Closed

Disposition-notification-to header #42

zharpaz-bmc-com opened this issue Jun 29, 2018 · 13 comments
Assignees
Milestone

Comments

@zharpaz-bmc-com
Copy link
Contributor

Hi Philip,

Looking at the headers of the message, I do not see the "Disposition-notification-to=email@acme.com" header. I thought it should be included in the message to signal that an MDN is required.

Thanks,
Ziv

@phax phax added the question label Jun 29, 2018
@phax phax self-assigned this Jun 29, 2018
@phax
Copy link
Owner

phax commented Jun 29, 2018

Indeed it is. But it must be part of the partnership.
It is applied here: https://github.com/phax/as2-lib/blob/master/as2-lib/src/main/java/com/helger/as2lib/processor/sender/AS2SenderModule.java#L446

hth, Philip

@zharpaz-bmc-com
Copy link
Contributor Author

I see. What about the option of working synchronously, but not asking for MDN?

Thanks,
Ziv

@phax
Copy link
Owner

phax commented Jun 29, 2018

If you mean you don't want an MDN - just do not send the header. As you can see in the code - if the partnership does not have the property, that header is not send, and no MDN is requested.
If you want an async MDN, add more headers.

@zharpaz-bmc-com
Copy link
Contributor Author

Hi,
when a message does not contain "Disposition-notification-to", and does contain the header "Disposition-Notification-Options", the server does return an MDN. (com.helger.as2lib.message.AS2Message#isRequestingMDN, line 106).
Does it conform to the standard?
(if I do not send it, I get the error 'The value of 'DigestAlgorithm' may not be null').

Thanks for your help,
Ziv

@phax
Copy link
Owner

phax commented Jun 29, 2018

Well according to chapter 2 of https://www.ietf.org/rfc/rfc3798.txt:

Message disposition notifications are requested by including a
Disposition-Notification-To header in the message. Further
information to be used by the recipient's MUA in generating the MDN
may be provided by also including Original-Recipient and/or
Disposition-Notification-Options headers in the message.
-> that would indicate that my implementation is incorrect.

I also didn't find any reference in RFC 4130. Any objections on deleting these checks?

@zharpaz-bmc-com
Copy link
Contributor Author

zharpaz-bmc-com commented Jul 1, 2018 via email

@phax
Copy link
Owner

phax commented Jul 1, 2018

It is already deleted in master branch. Please check the Snapshot version and tell me if it works.
I'm on vacation for one week so I will not respond.

@open-gdsn
Copy link

We are currently looking into use AS2-Lib as a replacement of our (previously certified) AS2 software. What should be kept in mind regarding interoperability is that in some case, the implementations of the certified software deviates from the specs if all certifying parties agreed on that in the certification process. Iirc (did not work here when the software was certified), these Drummond certification tests and reports can be found on the internet.

@phax
Copy link
Owner

phax commented Jul 25, 2018

@open-gdsn I'm aware of this, that's why I changed this. I just forked the project, because I needed an AS2 solution and OpenAS2 development was stalled. I updated the software so that it works for me (in the PEPPOL context) and for the rest I'm relying on community input.
So everytime you find an incompatibility just let me know. As an individual not having the resources to perform Drummond testing :(
Btw. I did not release a new version, because @zharpaz is building a PR with large file support which I want to investigate before releasing.

@open-gdsn
Copy link

Sorry, I now see I used my 'wrong' GitHub account, my name is Ronald van Kuijk, usually using '@kukel' (nickname) as Gitbub account. I'll keep monitoring things ;-)

@phax
Copy link
Owner

phax commented Jul 25, 2018

I think it has been tested thoroughly and will be included in the 4.1.1 release

@kukel
Copy link

kukel commented Aug 3, 2018

The value of the AS2MDNTo should (according to the specs) be in RFC2822 format and hence not being the AS2ID!. Although the spec also states that receiving systems should be very lenient, it is better to try to adhere to the specs.

7.3. Requesting a Signed Receipt

Message disposition notifications are requested as per RFC 3798. A
request that the receiving user agent issue a message disposition
notification is made by placing the following header into the message
to be sent:

    MDN-request-header = "Disposition-notification-to"
                        ":"  mail-address

The following example is for requesting an MDN:

    Disposition-notification-to: xxx@example.com

This syntax is a residue of the use of MDNs using SMTP transfer.
Because this specification is adjusting the functionality from SMTP
to HTTP while retaining as much as possible from the [4]
functionality, the mail-address MUST be present. The mail-address
field is specified as an RFC 2822 localpart@domain [addr-spec]
address. However, the address is not used to identify where to
return the MDN. Receiving applications MUST ignore the value and
MUST not complain about RFC 2822 address syntax violations.

@phax phax reopened this Aug 3, 2018
@phax phax added this to the 4.2.0 milestone Aug 6, 2018
@phax
Copy link
Owner

phax commented Aug 6, 2018

Next try :)

@phax phax closed this as completed Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants