Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flashlight not always turning on/off properly when used while walking/running. #213

Closed
Phazorknight opened this issue Jun 18, 2024 · 4 comments
Closed

Flashlight not always turning on/off properly when used while walking/running. #213

Phazorknight opened this issue Jun 18, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@Phazorknight
Copy link
Owner

Cogito and Godot Engine Version:
Cogito beta 202405.16 / Godot 4.2.1 stable

Description:
A clear and concise description of what the bug is.

Reproduction steps:

  1. Start scene.
  2. Pickup and equip flashlight.
  3. Start walking/running.
  4. While moving, click LMB to turn on/off flashlight.
  5. Flashlight animation and sound gets triggered, but on/off state doesn't get updated each time as expected.

Expected behavior:
Flashlight on/off state should update everytime the sound/animation plays.
@Phazorknight Phazorknight added the bug Something isn't working label Jun 18, 2024
KrysisDK added a commit to KrysisDK/Cogito that referenced this issue Jul 24, 2024
@KrysisDK
Issue Phazorknight#213 Flashlight fix + more features
d3edb7b 
- Fixed issue where flashlight does not turn on / off while running, walking, and spam clicking.
- Added cooldown for flashlight, so it cannot be rapidly turned on / off (for better immersion, but can ofc be adjusted)
- Flashlight animation will finish before it will play again (better immersion!)
@KrysisDK
Copy link
Contributor

I fixed this issue + added a few more features to the flashlight for immersion purposes on my fork.

Thank you for this git, it's truly an amazing time-saving project.

@Phazorknight
Copy link
Owner Author

@KrysisDK oh, would you mind putting in a pull request with your changes? Would love to take a look!

@KrysisDK
Copy link
Contributor

@Phazorknight Done, thanks again

@Phazorknight
Copy link
Owner Author

Amazing, thank you so much.

Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KrysisDK @Phazorknight