Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the once subcommand shows strange behaviour #44

Closed
amtoine opened this issue Jun 16, 2022 · 4 comments · Fixed by #50
Closed

the once subcommand shows strange behaviour #44

amtoine opened this issue Jun 16, 2022 · 4 comments · Fixed by #50
Labels
priority:medium Should not be harmful but still needs to be addressed rather quickly

Comments

@amtoine
Copy link
Collaborator

amtoine commented Jun 16, 2022

still testing the features of the script to understanding it better (@phenax note that my goal is not to open issues really, but to be able to solve the other ones and to tackle the PR reviews 😉)

bsp-layout once appears to work quite well on the current desktop, but i get the following when trying to change once the layout on another desktop:

~ ❯ bsp-layout once monocle 2
grep: 2$: No such file or directory
bash: Layout [/usr/local/lib/bsp-layout/layouts/monocle.sh] does not exist: No such file or directory
bash: Layout [/usr/local/lib/bsp-layout/layouts/monocle.sh] does not exist: No such file or directory
bash: Layout [/usr/local/lib/bsp-layout/layouts/monocle.sh] does not exist: No such file or directory

which looks suspiciously close to the following real error, as the layout does not exist

~ ❯ bsp-layout once djalwkd 2
grep: 2$: No such file or directory
bash: Layout [/usr/local/lib/bsp-layout/layouts/djalwkd.sh] does not exist: No such file or directory
bash: Layout [/usr/local/lib/bsp-layout/layouts/djalwkd.sh] does not exist: No such file or directory
bash: Layout [/usr/local/lib/bsp-layout/layouts/djalwkd.sh] does not exist: No such file or directory

HOWEVER, even though it is true that /usr/local/lib/bsp-layout/layouts/monocle.sh does not exist, bsp-layout set monocle 2 does work fine 😋

@amtoine
Copy link
Collaborator Author

amtoine commented Jun 16, 2022

And having a closer look at that, it looks like bsp-layout once * 2 is working... but on the current desktop only!
'cause the layout is changing, but on desktop 5 instead of the expected 2.

According to the man page of bsp-layout, this looks like a bug to me 😉

@phenax
Copy link
Owner

phenax commented Jun 16, 2022

I am unable to reproduce this issue from my end, can you confirm the script installed correctly and where all the files are installed?

@amtoine
Copy link
Collaborator Author

amtoine commented Jun 16, 2022

+ bsp-layout package:
i'm not able to get the version from bsp-layout

~ ❯ bsp-layout version
 

but

~ ❯ pacman -Q | grep bsp-layout
bsp-layout 0.0.10-1

+ the files:
below all the files installed with bsp-layout as, if i understood well, they should all go in /usr/

~ ❯ tree $(find bsp-layout /usr/)
 /usr/local/lib/bsp-layout
├──  layouts
│  ├──  even.sh
│  ├──  grid.sh
│  ├──  rgrid.sh
│  ├──  rtall.sh
│  ├──  rwide.sh
│  ├──  tall.sh
│  └──  wide.sh
├──  utils
│  ├──  common.sh
│  ├──  config.sh
│  ├──  desktop.sh
│  ├──  layout.sh
│  └──  state.sh
└──  layout.sh
 /usr/lib/bsp-layout
├──  layouts
│  ├──  even.sh
│  ├──  grid.sh
│  ├──  rgrid.sh
│  ├──  rtall.sh
│  ├──  rwide.sh
│  ├──  tall.sh
│  └──  wide.sh
├──  utils
│  ├──  common.sh
│  ├──  config.sh
│  ├──  desktop.sh
│  ├──  layout.sh
│  └──  state.sh
└──  layout.sh
 /usr/local/bin/bsp-layout -> /usr/local/lib/bsp-layout/layout.sh
 /usr/bin/bsp-layout -> /usr/lib/bsp-layout/layout.sh
 /usr/share/man/man1/bsp-layout.1
 /usr/local/man/man1/bsp-layout.1

@amtoine amtoine added unverified Might be a bug but needs more people to report it needs-triage Needs more investigation to determine the priority labels Jun 21, 2022
@phenax
Copy link
Owner

phenax commented Jun 23, 2022

@a2n-s let me know if #50 fixes this

@phenax phenax added priority:medium Should not be harmful but still needs to be addressed rather quickly and removed unverified Might be a bug but needs more people to report it needs-triage Needs more investigation to determine the priority labels Jun 23, 2022
@amtoine amtoine linked a pull request Jun 23, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium Should not be harmful but still needs to be addressed rather quickly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants