-
Notifications
You must be signed in to change notification settings - Fork 26
Adding .php_cs file as proposed by enebe-nb in #20 discussion #33
Conversation
Phergie (http://phergie.org) | ||
|
||
@link http://github.com/phergie/phergie-irc-bot-react for the canonical source repository | ||
@copyright Copyright (c) 2008-2015 Phergie Development Team (http://phergie.org) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the ending year be dynamic?
…e at start of doc block, and unable to verify header_comment is working.
Not sure |
I left the Now that i'm checking this, it only uses normal comment blocks to avoid conflict with doc blocks, but this way annotations won't work. Probably it won't help (although, the year is working). |
related to this: PHP-CS-Fixer/PHP-CS-Fixer#1297 |
Removed header. Once we finalize the Code Standards from #20 I'll update the .php_cs as needed and commit the changes files. |
Add custom fixer for discussed styling
@enebe-nb Having some issues with this command on travis:
There's always output even if there are no changes. We need to grep for "begin diff" or something similar when there is something to fix. I poked at it a couple times, couldn't get what would work locally to work with Travis. Possible option is not use this via travis if it's going to be a pain. |
…n 2 lines, exit with non 0 status code.
…more than 2 lines, exit with non 0 status code." This reverts commit 6b03986.
this command comes from my testing with that older version, it seem the exit code from cs-fixer changed many times. Probably using only I'll test it correctly. |
Using the command directly works, but it gets a "Undefined Class" error on hhvm |
Yeah I see, I'm not terribly worried about HHVM right now since we're still waiting for another issue with it to be resolved. Looks good, thanks for the work on this! |
Adding .php_cs file as proposed by enebe-nb in #20 discussion
Please discuss any changes here (if we need any before this is merged)