Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance Release: Forces And Motion Basics 2.1.11-rc.1 phet-io branch #187

Closed
7 tasks
zepumph opened this issue Sep 13, 2018 · 4 comments
Closed
7 tasks
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Sep 13, 2018

@samreid @kathy-phet @DianaTavares @jessegreenberg(responsible dev) FAMB is ready for a maintenance release.

This publication is to support a PhET-iO interaction study, see phetsims/forces-and-motion-basics#259 for details.

In the only code we added was on the wrapper side, with the exception of a new query parameter phet-io.emitStatesInterval.

The testing required for this release is to make sure that the features added are working as expected, as well as testing the full process that will be used in the upcoming study (i.e. recording to metacog).

This is a bit of a weird test, please bare with me, as I try to explain the important features to test.

First

please test the simulation as you would normally for a maintenance release. Make sure that on one or two devices, all the links works as expected, and play around with it for a few seconds.

Link to wrapper index

Notes:

  • You will need to add the ?launchLocalVersion query parameter (or &launchLocalVersion if there is already other query parameters) to each link in the index wrapper. I'm sorry.
  • As always it is good to note that this sim was originally published in Oct 2016. As a result, when finding bugs, see if the bug is present in the previous version and/or in master before creating an issue.

Second

Below is the link to the study link that records to the console, not to metacog:

https://phet-dev.colorado.edu/html/forces-and-motion-basics/2.1.11-rc.1/wrappers/iframe/iframe.html?url=../login/login.html?screens=2.3&wrapper=record&validationRule=validateDigits&encryption=encryptNumberV1&numberOfDigits=7&promptText=This%20is%20a%20test,%20enter%201000000%20as%20your%20id&publisher_id=5d4c8ae1&key_name=phet-study_2018_q4&widget_id=forces-and-motion-basics-qatest&phet-io.emitInputEvents=true&phet-io.emitStates=true&phet-io.emitStatesInterval=60&launchLocalVersion&console

  • Please test this link fully by entering in the prompted id, "1000000" and testing the redirected wrapper
  • Please also test that the phet-io.emitStatesInterval query parameters changes the number of "state" events in the console, where the number is the number of frames between states emitted. (~60 a second)

Third

Next test for metacog. In general this process involves running the link and playing with the sim for about 30 seconds, doing that a few times, then requesting that data from metacog, and then making sure that those sessions work as expected in the playback wrapper. Please follow the below steps as thoroughly as possible, unfortunately it is still quite complicated. This is the first time that QA has tested recording to metacog, and I look forward to feedback about the process. Many of the documentation links below point to https://github.com/phetsims/phet-io/blob/master/doc/metacog.md. This document will likely need updating and tweaking; please make recommendations!!

@ariel-phet has given me permission to mark this as top priority. Thank you all for you assistance!

@KatieWoe
Copy link
Contributor

@zepumph The developer's guide link on the wrapper index is broken.

@KatieWoe
Copy link
Contributor

KatieWoe commented Sep 14, 2018

General phet-io rc test done on these devices

  • Mac OS 10.13 chrome
  • Mac OS 10.13 firefox
  • Mac OS 10.13 safari
  • Win 10 chrome
  • Win 10 firefox
  • Win 10 edge
  • Chromebook chrome
  • Chromebook firefox
  • Chromebook edge

@zepumph
Copy link
Member Author

zepumph commented Sep 15, 2018

QA is done, and phetsims/forces-and-motion-basics#267 published to production. Closing. Thank you so much to @KatieWoe and @lmulhall-phet!!!

@zepumph zepumph closed this as completed Sep 15, 2018
@zepumph
Copy link
Member Author

zepumph commented Sep 15, 2018

Good to note that the "generate/launch" features of instance proxies don't work in RC for this version (likely because they were designed with hard coded "spot" specific links), but the production links work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants