Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev test: Gravity Force Lab 2.2.0-dev.16 #455

Closed
12 of 13 tasks
zepumph opened this issue Nov 7, 2019 · 6 comments
Closed
12 of 13 tasks

Dev test: Gravity Force Lab 2.2.0-dev.16 #455

zepumph opened this issue Nov 7, 2019 · 6 comments
Assignees
Labels

Comments

@zepumph
Copy link
Member

zepumph commented Nov 7, 2019

Hello QA!

@jessegreenberg @kathy-phet @twant, @emily-phet, @terracoda, gravity-force-lab 2.2.0-dev.16 is ready for dev testing. This dev test is trying to kill two birds with a single, quality (that's your job), stone. There are both PhET-iO and accessibility items to address in this issue.

Gravity Force Lab has undergone a large amount of development work adding sonification and interactive descriptions. It has also recently been polished up for PhET-iO and delivered (as a preliminary dev version) to a client. So it will be good to make sure that things look as expected in general.

See the respective sections for details on what to test for each feature. Thanks and good luck!

Document issues in https://github.com/phetsims/gravity-force-lab/issues and link to this issue.

Assigning @ariel-phet for prioritization.

General Dev Test

What to Test

  • Click every single button.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • If there is a console available, check for errors and include them in the Problem Description.
  • Rung through the string tests on at least one platform, especially if it is about to go to rc.

Focus and Special Instructions

[Provide further instructions here. If you have any further tests you want done or specific platforms you want tested, list them here. Any behaviors you want QA to pay special attention to should be listed here.]

General Dev Test Platforms

  • Latest macOS, Chrome and Safari
  • Latest iOS, Safari
  • Windows 10, all browsers
  • Latest Chrome OS, Chrome

Link(s)


PhET-iO Dev Test

This simulation may soon be published for PhET-iO, this is a great time to get a head start on testing the wrapper suite and the phet-io branded sim to see if anything is trouble (before going to RC)

What to Test

  • Make sure that public files do not have password protection. Use a private browser for this.
  • Make sure that private files do have password protection. Use a private browser for this.
  • Make sure standalone sim is working properly.
  • Make sure the wrapper index is working properly.
  • Make sure each wrapper is working properly.
  • Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
  • For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make sure the simulation loads without crashing or throwing errors.

General Dev Test Platforms

  • Latest macOS, all browsers
  • Latest iOS, Safari
  • Windows 10, all browsers
  • Latest Chrome OS, Chrome

Link(s)


Accessibility (a11y) Dev Test

The main goal for a11y testing is that recently, as part of phetsims/utterance-queue#1, aria-live alerts via the utterance queue were moved to scenery. This was a large refactor that touched every place where alerts are triggered. It would be good to make sure that all devices/platforms have not broken alerts. This is especially important because this sim and Molarity are hoping to be published in the coming month or two.

What to Test

  • Specific instructions can be found below.
  • Make sure the a11y feature testing doesn't negatively affect the sim in any way.
  • Load the a11y view and make sure that interacting with all elements in the simulation updates the appropriate descriptions in the PDOM.

Focus and Special Instructions

[Provide further instructions here. If you have any further tests you want done or specific platforms you want tested, list them here. Any behaviors you want QA to pay special attention to should be listed here.]

Issues to Verify

These issues should have either use the labels "status:ready-for-qa" or "status:ready-for-review." If it is ready for QA then close the issue if fixed. If ready for review then leave open and assign back to the developer.

Link(s)

Screen Readers

This sim supports screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to screen readers. If you simply need a refresher on screen readers, please consult the QA Book, which should have all of the information you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

  • Windows 10 + Latest Chrome + Latest JAWS
  • Windows 10 + Latest Firefox + Latest NVDA
  • macOS + Safari + VoiceOver
  • iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information

We are tracking known screen reader bugs in this Google Document. If you find a screen reader bug, please check it against this list.

Keyboard Navigation

This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a screen reader.


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@ghost
Copy link

ghost commented Nov 7, 2019

For QA:

  • Make sure JAWS + Chrome reads alerts in fullscreen mode.
  • Make sure VoiceOver + Safari reads alerts in fullscreen mode.
  • Also test other supported screenreaders + platforms to see if anything is broken.

See phetsims/molarity#155 and phetsims/utterance-queue#1.

@KatieWoe
Copy link
Contributor

KatieWoe commented Nov 8, 2019

General lag on Win 10. Should be acceptable.

@KatieWoe
Copy link
Contributor

I find it a bit odd that arrows this size are considered small. Can you comment on this decision @zepumph?
sizingseemsodd

@zepumph
Copy link
Member Author

zepumph commented Nov 13, 2019

Yes. I think it is reasonable to find that strange, the reason is in relation to the max range, which get's quite huge, especially when close with constant checkbox checked. In terms of a definite solution. It would be good to make an issue and assign to @terracoda to double check those regions. Note that they were looked at "recentlyish" in phetsims/gravity-force-lab#178 (comment)

@ghost
Copy link

ghost commented Nov 14, 2019

Katie wanted to close this issue after I finished making phetsims/gravity-force-lab#202. QA is done. Closing.

@ghost ghost closed this as completed Nov 14, 2019
@ghost ghost reopened this Nov 14, 2019
@ghost
Copy link

ghost commented Nov 14, 2019

Whoops, I'll let @zepumph close, but QA is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants