Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev test: Energy Skate Park 1.0.0-dev.6 #470

Closed
jessegreenberg opened this issue Jan 27, 2020 · 13 comments
Closed

Dev test: Energy Skate Park 1.0.0-dev.6 #470

jessegreenberg opened this issue Jan 27, 2020 · 13 comments
Assignees
Labels
QA:dev-test Dev test before an RC

Comments

@jessegreenberg
Copy link
Contributor

Could you please give this sim a dev test? There have been enough changes since the last version that this would be useful before an RC.

Changes mostly involve conservation of energy in special cases (phetsims/energy-skate-park#172, phetsims/energy-skate-park#45, others). So please pay special attention to the behavior of energy and make sure that it is conserved.

For this test can you also please test performance of the sim on our slowest platforms?

Link to Sim

Also assigning to @ariel-phet to provide priority.

@jessegreenberg jessegreenberg added the QA:dev-test Dev test before an RC label Jan 27, 2020
@ariel-phet ariel-phet removed their assignment Jan 28, 2020
@ariel-phet
Copy link
Contributor

Promoting to current top priority

@ariel-phet
Copy link
Contributor

And back to the top priority

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 13, 2020

  • Latest macOS, Chrome and Safari
  • Latest iOS, Safari
  • Windows 10, all browsers
  • Latest Chrome OS, Chrome

@KatieWoe
Copy link
Contributor

I believe QA is done with this dev test

@jessegreenberg
Copy link
Contributor Author

Great, thank you @KatieWoe and team -

For this test can you also please test performance of the sim on our slowest platforms?

I am not sure #470 (comment) covered this, can you comment on if any slower platforms were tested? Ideally we want to catch performance issues now before we create an RC branch.

@KatieWoe
Copy link
Contributor

Ah, sorry. I missed the bit about slowest performing. I'll reopen and take a look.

@jessegreenberg
Copy link
Contributor Author

Thank you!

@KatieWoe
Copy link
Contributor

ChromeOS: Fair, some noticeable lag, particularly on third screen. FPS from 30-50
iOS 9 (not supported): Poor, prone to crashing, Normal and slow look similar/same
Mac OS 10.10 Safari: Good, no problems seen

@jessegreenberg
Copy link
Contributor Author

Great, thanks @KatieWoe -

In phetsims/energy-skate-park#42 we decided that this release will not need to support iOS 9, we expected that platform to be problematic.

@ariel-phet can you please comment on if more time is needed to optimize for ChromeOS? Third screen is most graphically intensive as it uses griddle, and optimizations would probably start there. But "fair" with 30-50 fps may also be acceptable.

@ariel-phet
Copy link
Contributor

@KatieWoe for ChromeOS can you compare to the published version of ESPB for us? If things have some lag compared to published, we likely need to do some work @jessegreenberg considering the popularity of this platform.

@KatieWoe
Copy link
Contributor

Quick look on published ESPB ChromeOS. It looked good: 55-60 fps. Honestly, I expected to get problems from phetsims/energy-skate-park-basics#467, but it looks pretty good.

@KatieWoe KatieWoe removed their assignment Feb 19, 2020
@jessegreenberg
Copy link
Contributor Author

Interesting, that is surprising since it was reported as poor in phetsims/energy-skate-park-basics#467. Ill open an issue in energy-skate-park to investigate more. This issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:dev-test Dev test before an RC
Projects
None yet
Development

No branches or pull requests

3 participants