Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance screens spot-check #656

Closed
jonathanolson opened this issue Jun 10, 2021 · 7 comments
Closed

Maintenance screens spot-check #656

jonathanolson opened this issue Jun 10, 2021 · 7 comments

Comments

@jonathanolson
Copy link
Contributor

jonathanolson commented Jun 10, 2021

I'd like all release branches to briefly be tested to see if they support comma-based screens (e.g. ?screens=1,2 should show 2 screens on a sim with 2+ screens). This will NOT apply to single-screen sims, please ignore those. This problem was noticed in #653 (comment).

So:

  1. For any sim with 2+ screens, try the ?screens=1,2 query parameter. It should show 2 screens (it is buggy if it just shows 1 screen)
  2. Ideally test Adjust max width values to better support Arabic (and other) translations blackbody-spectrum#124 for blackbody-spectrum, since it's been wrapped in.
  3. For any sim marked with a patch for Maintenance release spot-check testing #653, do a short 10-second test to see if it's horribly broken (these are the sims that were auto-patched).

acid-base-solutions 1.2 (phetsims/scenery#983, phetsims/joist#714, phetsims/axon#355, phetsims/joist#717, #653)

area-builder 1.1 (phetsims/scenery#983, phetsims/joist#714, phetsims/joist#717, #653)

area-model-algebra 1.2 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

area-model-decimals 1.2 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

area-model-introduction 1.2 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

area-model-multiplication 1.2 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

arithmetic 1.0 (phetsims/scenery#983, phetsims/joist#714, phetsims/axon#355, phetsims/joist#717, #653)

atomic-interactions 1.2 (phetsims/scenery#1199, phetsims/scenery#1218, phetsims/joist#641, phetsims/scenery#1222)

balancing-act 1.1 (phetsims/scenery#983, phetsims/joist#714, phetsims/joist#717, #653)

balancing-act 1.2 (phetsims/scenery#1199, phetsims/chipper#1032, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/joist#717)

balancing-chemical-equations 1.2 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

balloons-and-static-electricity 1.3-phetio (phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714)

balloons-and-static-electricity 1.4 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

beers-law-lab 1.4 (phetsims/scenery#983, phetsims/joist#714, phetsims/joist#717, #653)

beers-law-lab 1.6-phetio (phetsims/scenery#983, phetsims/joist#714, phetsims/joist#717)

bending-light 1.1 (phetsims/scenery#983, phetsims/joist#714, phetsims/joist#717, #653)

blackbody-spectrum 1.0 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

build-a-fraction 1.0 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

build-a-molecule 1.0 (phetsims/scenery#1199, phetsims/scenery#1218, phetsims/scenery#1222)

build-an-atom 1.5-phetio (phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/joist#717)

build-an-atom 1.6 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/joist#717)

capacitor-lab-basics 1.6 (phetsims/scenery#1199, phetsims/capacitor-lab-basics#291, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/scenery#1224)

charges-and-fields 1.0 (phetsims/scenery#983, phetsims/joist#714, #653)

charges-and-fields 1.0-phetio (phetsims/scenery#983, phetsims/joist#714)

circuit-construction-kit-black-box-study 1.1-phetio (phetsims/scenery#983, phetsims/joist#714, phetsims/joist#717)

circuit-construction-kit-dc 1.2 (phetsims/scenery#1199)

circuit-construction-kit-dc-virtual-lab 1.2 (phetsims/scenery#1199)

collision-lab 1.1 (phetsims/scenery#1199)

color-vision 1.1 (phetsims/scenery#983, phetsims/joist#714, phetsims/joist#717, #653)

color-vision 1.2-phetio (phetsims/scenery#983, phetsims/joist#714, phetsims/joist#717, #653)

concentration 1.3 (phetsims/scenery#983, phetsims/joist#714, #653)

concentration 1.5-phetio (phetsims/scenery#983, phetsims/joist#714, #653)

coulombs-law 1.0 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

curve-fitting 1.0 (phetsims/scenery#1199, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

diffusion 1.0 (phetsims/scenery#1199, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

energy-forms-and-changes 1.4 (phetsims/scenery#1199, phetsims/scenery#1218, phetsims/scenery#1222)

energy-skate-park 1.1 (phetsims/scenery#1199)

energy-skate-park-basics 1.1 (phetsims/scenery#983, phetsims/joist#714, phetsims/joist#717, #653)

energy-skate-park-basics 1.3-phetio (phetsims/scenery#983, phetsims/joist#714, phetsims/joist#717)

equality-explorer 1.0 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/equality-explorer#166)

equality-explorer-basics 1.0 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/equality-explorer#166)

equality-explorer-two-variables 1.0 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/equality-explorer#166)

expression-exchange 1.1 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/joist#717)

faradays-law 1.3-phetio (phetsims/scenery#983, phetsims/joist#714, #653)

faradays-law 1.4 (phetsims/scenery#1199)

forces-and-motion-basics 2.1-phetio (phetsims/scenery#983, phetsims/joist#714, phetsims/joist#717, #653)

forces-and-motion-basics 2.3 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/joist#717)

fraction-matcher 1.2 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

fractions-equality 1.1 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

fractions-intro 1.0 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

fractions-mixed-numbers 1.0 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

friction 1.5 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

function-builder 1.0 (phetsims/scenery#983, phetsims/joist#714, phetsims/joist#717, #653)

function-builder-basics 1.0 (phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/joist#717)

gas-properties 1.0 (phetsims/scenery#1199, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

gases-intro 1.0 (phetsims/scenery#1199, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

gene-expression-essentials 1.0 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/joist#717)

graphing-lines 1.3 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

graphing-quadratics 1.1 (phetsims/scenery#1199, phetsims/chipper#1032, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

graphing-slope-intercept 1.1 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

gravity-and-orbits 1.4 (phetsims/scenery#1199)

gravity-force-lab 2.2 (phetsims/scenery#1199, phetsims/chipper#1032, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

gravity-force-lab-basics 1.0 (phetsims/scenery#1199, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

hookes-law 1.0 (phetsims/scenery#983, phetsims/joist#714, phetsims/axon#355, phetsims/joist#717, #653)

isotopes-and-atomic-mass 1.1 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

john-travoltage 1.4-phetio (phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714)

john-travoltage 1.5 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

least-squares-regression 1.1 (phetsims/scenery#983, phetsims/joist#714, #653)

make-a-ten 1.0 (phetsims/scenery#983, phetsims/joist#714, phetsims/joist#717)

masses-and-springs 1.0 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

masses-and-springs-basics 1.0 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

molarity 1.4 (phetsims/scenery#1199, https://github.com/phetsims/phet-io/issues/1742, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/scenery#1224)

molarity 1.5 (phetsims/scenery#1199, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

molecule-polarity 1.0 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/joist#717)

molecule-shapes 1.2 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/molecule-shapes#179)

molecule-shapes-basics 1.2 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/molecule-shapes#179)

molecules-and-light 1.3-phetio (phetsims/scenery#983, phetsims/joist#714, #653)

molecules-and-light 1.5 (phetsims/scenery#1199, phetsims/scenery#1218, phetsims/scenery#1222)

natural-selection 1.1 (phetsims/scenery#1199)

natural-selection 1.2 (phetsims/scenery#1199, phetsims/scenery#1218)

natural-selection 1.3 (phetsims/chipper#1032)

neuron 1.1 (phetsims/scenery#983, phetsims/joist#714, #653)

number-line-integers 1.1 (phetsims/scenery#1199)

number-line-operations 1.0 (phetsims/scenery#1199)

ohms-law 1.4 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

pendulum-lab 1.0 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/joist#717)

ph-scale 1.3 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

ph-scale-basics 1.3 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

plinko-probability 1.1 (phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/joist#717)

projectile-motion 1.0 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/joist#717)

proportion-playground 1.0 (phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/joist#717)

ratio-and-proportion 1.0 (phetsims/scenery#1199)

reactants-products-and-leftovers 1.2 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

resistance-in-a-wire 1.3-phetio (phetsims/scenery#1199, phetsims/capacitor-lab-basics#291, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/scenery#1224)

resistance-in-a-wire 1.6 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

rutherford-scattering 1.1 (phetsims/scenery#1199, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

states-of-matter 1.2 (phetsims/scenery#1199, phetsims/scenery#1218, phetsims/joist#641, phetsims/scenery#1222)

states-of-matter-basics 1.2 (phetsims/scenery#1199, phetsims/scenery#1218, phetsims/joist#641, phetsims/scenery#1222)

trig-tour 1.0 (phetsims/scenery#983, phetsims/joist#714, #653)

under-pressure 1.1 (phetsims/scenery#983, phetsims/joist#714, #653)

unit-rates 1.0 (phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/joist#717)

vector-addition 1.0 (phetsims/scenery#1199, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

vector-addition-equations 1.0 (phetsims/scenery#1199, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

wave-interference 2.0 (phetsims/scenery#1199, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222)

wave-on-a-string 1.1 (phetsims/scenery#983, phetsims/joist#714, #653)

waves-intro 1.1 (phetsims/scenery#1199)

@jonathanolson
Copy link
Contributor Author

jonathanolson commented Jun 14, 2021

@KatieWoe
Copy link
Contributor

@jonathanolson I don't have a device that has a screen refresh rate to test for the issue. Is there another way to test it?

@jonathanolson
Copy link
Contributor Author

@jonathanolson I don't have a device that has a screen refresh rate to test for the issue. Is there another way to test it?

I'm not aware of a great test method, maybe talk to @jbphet? Maybe the speed query parameter could be used (but I'd confirm first with JB)

@jbphet
Copy link
Contributor

jbphet commented Jun 14, 2021

@KatieWoe said:

I don't have a device that has a screen refresh rate to test for the issue. Is there another way to test it?

@phet-steele had the only device on which this problem occurred, so I would suggest having him test for it on the RC. If that's not possible, I would just suggest regression testing the pressure behavior and calling it good, making sure that the behavior seems correct and the performance hasn't dropped significantly. I was able to do some "white box" testing where I intentionally under-allocated memory for the data queue that was holding and averaging pressure samples and verifying that the allocation of additional memory worked correctly, so I feel decently confident about the fix.

@phet-steele
Copy link
Contributor

I checked all the links in #656 (comment) for phetsims/states-of-matter/issues/354, and they all correctly calculated pressure. I tried both Win 10 Chrome and FF.

@KatieWoe
Copy link
Contributor

QA is done

@jonathanolson
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants