Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS code must be linted #10

Closed
samreid opened this issue Oct 24, 2016 · 5 comments
Closed

JS code must be linted #10

samreid opened this issue Oct 24, 2016 · 5 comments
Assignees
@samreid

Comments

@samreid
Copy link
Member

samreid commented Oct 24, 2016

We should add a way to lint the aqua JS code.
@samreid samreid self-assigned this Oct 24, 2016
@samreid
Copy link
Member Author

samreid commented Oct 24, 2016

For instance, cd aqua; grunt lint should report lint errors for aqua.

@samreid samreid mentioned this issue Oct 24, 2016
Closed
@samreid
Copy link
Member Author

samreid commented Oct 31, 2016

I'm not planning to work on aqua for a while, unassigning.

@samreid samreid removed their assignment Oct 31, 2016
@samreid
Copy link
Member Author

samreid commented Dec 2, 2017 •
edited
Loading

@jonathanolson does bayes lint-everything hit aqua JS code? If so, please close this issue.

@jonathanolson
Copy link
Contributor

It lints the version of aqua code that is being run (which is not always the latest master, since aqua won't pull itself). Is that sufficient?

@samreid
Copy link
Member Author

samreid commented Dec 8, 2017

That seems sufficient for now since that file isn't changing too much, and when it does change we probably pull it on bayes.

@samreid samreid closed this as completed Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @samreid