Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhET-iO instrumentation design plan #36

Open
chrisklus opened this issue Sep 27, 2018 · 6 comments
Open

PhET-iO instrumentation design plan #36

chrisklus opened this issue Sep 27, 2018 · 6 comments

Comments

@chrisklus
Copy link
Contributor

chrisklus commented Sep 27, 2018

No description provided.

@jbphet
Copy link
Contributor

jbphet commented Sep 27, 2018

Notes for 9/27/2018 meeting with @kathy-phet, @ariel-phet< @DianaTavares, @samreid, @chrisklus, @arouinfar, and myself.

The following items should be instrumented:

  • all buttons
  • all checkboxes
  • the slider
  • the cuing arrows (separate from the slider)
  • the B-G-R and star display should be instrumented as a single unit
  • the unit conversion on the x axis that says 1 um = 1000 nm
  • the control panel that contains the buttons and the check boxes
  • the "Graph Values" dot
  • the arrows associated with the "Graph Values" dot
  • the temperature readout
  • the "Blackbody Temperature" label
  • the thermometer as a whole
  • the benchmarks on the thermometer so that they can be turned off
  • the save key panel (shown when lines have been saved)
  • the spectrum
  • saving the state, should include:
    • temperature
    • from @chrisklus - slider?
    • check box states
    • saved curves
    • zoom levels
    • green dot state
    • intensity (in W/m^2)

We discussed whether the values that are shown on the X and Y axes should be instrumented, thus allowing them to be hidden. We decided against doing this, but would be willing to do it if a client requested this feature.

We also discussed whether to allow hiding of the curve, and decided against, but would add it if a client requested it.

@jbphet
Copy link
Contributor

jbphet commented Sep 27, 2018

Our plan is to do this after the code review. I'll leave it unassigned for now, and will assign to @chrisklus when we're getting close on this.

@samreid
Copy link
Member

samreid commented Mar 5, 2019

Please see https://docs.google.com/document/d/1OfHhIDuaBt-hhXVtpnJgM3Wm0iByJ7dmXd-2UkphUR4/edit# for a reference of Graphing Quadratics PhET-iO design.

And see https://github.com/phetsims/phet-io/blob/master/doc/how-to-design-phet-io-features-for-a-simulation.md for instructions for how to design for PhET-iO.

@jbphet
Copy link
Contributor

jbphet commented May 16, 2019

A few weeks ago we discussed whether this sim should go to RC with both PhET and PhET-iO brands.
At the time, we decided to defer that decision until we were closer to publication. @chrisklus said that the instrumentation of the sim itself would not block the PhET-iO brand testing and publication, so it is the state of the common code and PhET-iO library code that would likely be the determining factor.

In the 5/16/2019 developer meeting, I said that I think this sim is about two weeks away from an RC, and asked if the PhET-iO code infrastructure was likely to be in a state where PhET-iO brand could and should be published. @pixelzoom pointed out that Graphing Quadratics is currently blocked from publishing PhET-iO brand due to several issues, including:

  • common code needs to be updated such that some components are marked as "featured" by default
  • studio has to be ready to go to support the specification of the blackbody-spectrum tandems
  • the activity has to be done by the designers to actually specify blackbody-spectrum featured items

My impression from this discussion was that it is pretty unlikely that things will be in a state to support the simultaneous testing and release of the PhET and PhET-iO brands. My recommendation would be to plan to only go for PhET brand for the first release.

Assigning to @ariel-phet to see if he concurs. Tagging @arnabp and @kathy-phet so that they are aware and can comment if they feel the need.

@jbphet jbphet assigned ariel-phet and unassigned chrisklus May 16, 2019
@ariel-phet
Copy link

@jbphet @arnabp I concur. PhET-brand should be published without worrying about publishing an iO brand simultaneously.

@ariel-phet ariel-phet assigned jbphet and arnabp and unassigned ariel-phet May 21, 2019
@jbphet jbphet removed their assignment May 21, 2019
@arnabp
Copy link
Contributor

arnabp commented Aug 27, 2019

The sim was published without iO. Assigning to @chrisklus to take notice when the noted PhET-iO issues have been resolved to a state so the PhET-iO brand of blackbody can be published.

@arnabp arnabp assigned chrisklus and unassigned arnabp Aug 27, 2019
@chrisklus chrisklus removed their assignment May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants