-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The speed at which some objects return to their position seems unusually fast #22
Comments
Nice catch @Nancy-Salpepi! Agreed the animation should be slowed. How this is issue is fixed will partially depend on decisions made in #24. I will also remember to tweak the animation speed of the ten frames. Marking on hold until #24 gets feedback. |
Discussed with @chrisklus . This should be improved with #24 . Let's check it after that is updated, but I'm inclined to leave this as-is because the number cards are using Fractions code. It's a really wide carousel, so an object that must fly really far will fly faster, but I think it will not be too bad after #24. It also is probably not worth the hassle to make this change. We could make the change to the ten frames and comparison symbols, though, since that is Number Suite Common code, but I didn't think it seemed too fast. However I'm fine if we want to change those to match the speed of the objects. |
Update: looks like it is number suite common code, and @chrisklus can change it. @chrisklus will change all of these animations to be constant speed. |
For @zepumph: the countingObjects are doing it right |
#24 is closed, unholding! |
Changes committed above to match all of the animation styles. @zepumph and I have separately verified on our own machines that this is working since @Nancy-Salpepi is out for the remainder of the day and we would like to open a NP dev test! Closing. |
Test device
MacBook Air M1 chip
Operating System
13.2.1
Browser
Safari
Problem description
For phetsims/qa#917, on the Lab Screen:
If I grab a card (number, symbol or ten card) and let go, the speed that it returns to its original location seems to be much faster than I am used to seeing in sims. It is also faster than when an object, such as a dog, moves back to its toolbox.
Steps to reproduce
Visuals
speedofcards.mp4
The text was updated successfully, but these errors were encountered: