Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The speed at which some objects return to their position seems unusually fast #22

Closed
Nancy-Salpepi opened this issue Mar 15, 2023 · 6 comments
Assignees
Labels
type:bug Something isn't working

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
13.2.1

Browser
Safari

Problem description
For phetsims/qa#917, on the Lab Screen:
If I grab a card (number, symbol or ten card) and let go, the speed that it returns to its original location seems to be much faster than I am used to seeing in sims. It is also faster than when an object, such as a dog, moves back to its toolbox.

Steps to reproduce

  1. On the lab screen, grab the 1 card and move it over the 10 card
  2. Let go

Visuals

speedofcards.mp4
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Number Compare‬ URL: https://phet-dev.colorado.edu/html/number-compare/1.0.0-dev.6/phet/number-compare_all_phet.html Version: 1.0.0-dev.6 2023-03-15 01:30:22 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.3 Safari/605.1.15 Language: en-US Window: 1203x654 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@Nancy-Salpepi Nancy-Salpepi added the type:bug Something isn't working label Mar 15, 2023
@chrisklus
Copy link
Contributor

Nice catch @Nancy-Salpepi! Agreed the animation should be slowed. How this is issue is fixed will partially depend on decisions made in #24. I will also remember to tweak the animation speed of the ten frames. Marking on hold until #24 gets feedback.

@amanda-phet
Copy link
Contributor

Discussed with @chrisklus .

This should be improved with #24 . Let's check it after that is updated, but I'm inclined to leave this as-is because the number cards are using Fractions code. It's a really wide carousel, so an object that must fly really far will fly faster, but I think it will not be too bad after #24. It also is probably not worth the hassle to make this change.

We could make the change to the ten frames and comparison symbols, though, since that is Number Suite Common code, but I didn't think it seemed too fast. However I'm fine if we want to change those to match the speed of the objects.

@amanda-phet
Copy link
Contributor

Update: looks like it is number suite common code, and @chrisklus can change it.

@chrisklus will change all of these animations to be constant speed.

@chrisklus
Copy link
Contributor

For @zepumph: the countingObjects are doing it right

@zepumph
Copy link
Member

zepumph commented Mar 30, 2023

#24 is closed, unholding!

@chrisklus
Copy link
Contributor

Changes committed above to match all of the animation styles. @zepumph and I have separately verified on our own machines that this is working since @Nancy-Salpepi is out for the remainder of the day and we would like to open a NP dev test! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants