-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Number cards fly off screen when attempting to return to carousel #24
Comments
Thanks @Nancy-Salpepi! This is because the numbers are returning to their home locations relative to the visible set of numbers on the carousels. For a number that doesn't belong in the visible set, its home spot is going to be off screen to the right or the left. I agree that it's weird, but I'm not sure what a better experience would be - immediately disappearing into the carousel doesn't seem great. Maybe a more reasonable animation speed so it doesn't look as buggy? It would be great if @pixelzoom and @amanda-phet could weigh in here. |
Other sims with carousel that I've worked on (Function Builder, ...) make the objects immediately disappear into the carousel. And I see that's also what is done in CCK. So imo, that's what should be done here. In other sims, we had also experimented with automatically scrolling the carousel so that the object's "slot" in the carousel is visible. We found that to be too distruptive/confusing to the user experience. |
I just reviewed a bunch of other carousels and there seems to be a standard behavior where the object flies back toward its original location even if the stack/spot isn't visible. I would like to do the same here. Thanks for finding this @Nancy-Salpepi . Assigning to @chrisklus to implement the change. |
I was unclear in how I described the behavior. I showed @chrisklus the behavior in Expression Exchange and Fractions: Intro of an object flying back toward its home location as if the home page was visible. I am also totally ok with having the object disappear over the carousel as it happens in CCK, if that's easier to implement. @chrisklus is going to start by looking into the behavior seen in Expression Exchange and Fractions: Intro. |
@zepumph and I investigated and found it was pretty easy to make the cards go back to their home location (as if that page was still visible). @Nancy-Salpepi can you check this out on phettest and see how it feels? Please note we have yet to make the speed change in #22 (though it is next up). |
…ome node currently is, see phetsims/number-compare#24
This looks good. Exactly what I was expecting based on my experience with Function Builder! Looking forward to seeing it once #22 is fixed! Closing! |
Test device
MacBook Air M1 chip
Operating System
13.2.1
Browser
Safari
Problem description
For phetsims/qa#917, on the Lab Screen:
When attempting to return a number card from page 1 of the carousel with page 2 showing (or vise versa), that number will look like it is flying off screen.
Steps to reproduce
Visuals
I used ?speed=.5 to make the video:
numbersflyingoff.mp4
The text was updated successfully, but these errors were encountered: