Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Test: keplers-laws 1.2.0-rc.1 #1034

Closed
5 tasks done
AgustinVallejo opened this issue Feb 2, 2024 · 6 comments
Closed
5 tasks done

RC Test: keplers-laws 1.2.0-rc.1 #1034

AgustinVallejo opened this issue Feb 2, 2024 · 6 comments
Assignees

Comments

@AgustinVallejo
Copy link

AgustinVallejo commented Feb 2, 2024

RC Test

Mentions: @AgustinVallejo @zepumph @DianaTavares @arouinfar

Simulation links

Test Matrices

Features included

  • PhET-iO
  • Alternative Input
  • UI Sound
  • Sonification
  • Dynamic Locale

Issues to Verify

These issues should have the "status:ready-for-review" label. Unless an issue says to close after verifying, assign the
issue back to the developer.

  • N/A

For QA...

General features

What to Test

  • Click every single button.
  • Test all possible forms of input.
    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Test all query parameters on all platforms. (
    See QA Book for a list of query parameters.)
  • Download HTML on Chrome and iOS.
  • Make sure the iFrame version of the simulation is working as intended on all platforms.
  • Make sure the XHTML version of the simulation is working as intended on all platforms.
  • Complete the test matrix.
  • Don't forget to make sure the sim works with Legends of Learning.
  • Test the Game Up harness on at least one platform.
  • Check this LoL
    spreadsheet and notify AR or AM if it not there.
  • If this is rc.1 please do a memory test.
  • When making an issue, check to see if it was in a previously published version.
  • Try to include version numbers for browsers.
  • If there is a console available, check for errors and include them in the Problem Description.
  • As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if there
    is a problem.
  • As the RC ends, please review the QA credits in the about dialog. If the QA credits are complete and correct, please
    add a comment in the RC test issue indicating so. If not, please open a new issue and specify what changes should be
    made.

PhET-iO features

What to Test

  • Make sure that public files do not have password protection. Use a private browser for this.
  • Make sure that private files do have password protection. Use a private browser for this.
  • Make sure standalone sim is working properly.
  • Make sure the wrapper index is working properly.
  • Make sure each wrapper is working properly.
  • Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
  • For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
    sure the simulation loads without crashing or throwing errors.
  • Load the login wrapper just to make sure it works. Do so by adding this link from the sim deployed root:
    /wrappers/login/?wrapper=record&validationRule=validateDigits&&numberOfDigits=5&promptText=ENTER_A_5_DIGIT_NUMBER
    
    Further instructions in QA Book
  • Conduct a recording test to Metacog, further instructions in the QA Book. Do this for iPadOS + Safari and one other
    random platform.
  • Conduct a memory test on the stand alone sim wrapper (rc.1).
  • Test one platform combination with ?phetioDebug=true on the Studio and State wrapper.
  • If Pan/Zoom is supported, make sure that it works when set with PhET-iO State.
  • Test that the sim works offline:
    • Click the link to the phet-io zip file (at top of issue) to download the zip file.
    • Unzip it to a spot locally.
    • Open index.html by double clicking it on your desktop or in a Finder-view.
    • It should look like the standalone version of the sim in PhET-iO brand.

Accessibility features

What to Test

  • Specific instructions can be found above.

  • Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
    a list of features that may be supported in this test:

    • Alternative Input
    • Sound and Sonification
    • Pan and Zoom
  • Test all possible forms of input.

    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
    • Test all keyboard navigation inputs (if applicable).
    • Test all forms of input with a screen reader (if applicable).
  • If this sim is not in this list or up to date there, make an
    issue in website to ask if PhET research page links need updating. Please
    assign to @terracoda and @emily-phet.

Keyboard Navigation

This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.

Magnification

This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel
controls. Please test magnfication and make sure it is working as intended and well with the use cases of the
simulation. Due to the way screen readers handle user input, magnification is NOT expected to work while using a screen
reader so there is no need to test this case.


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 5, 2024

Memory test looked large, but didn't seem to have any leaks.
PhET:
kepmem
PhET-iO:
kepiomem

@zepumph
Copy link
Member

zepumph commented Feb 7, 2024

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 7, 2024

This occurs in published, so I'm not sure if it's worth an issue, but orbits with high eccentricity can get jumpy.

Kepler.s.Laws.Mozilla.Firefox.2024-02-07.16-19-00.mp4

@Nancy-Salpepi
Copy link
Contributor

@KatieWoe maybe add your above comment to phetsims/keplers-laws#219?

@Nancy-Salpepi
Copy link
Contributor

QA is done!

AgustinVallejo added a commit to phetsims/keplers-laws that referenced this issue Feb 15, 2024
@AgustinVallejo
Copy link
Author

RC spot check issued in #1044. Closing this one. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

5 participants