Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Test: iOS app 1.2(27) #218

Closed
mattpen opened this issue Nov 7, 2018 · 12 comments
Closed

Dev Test: iOS app 1.2(27) #218

mattpen opened this issue Nov 7, 2018 · 12 comments
Assignees
Labels
QA:dev-test Dev test before an RC

Comments

@mattpen
Copy link
Contributor

mattpen commented Nov 7, 2018

QA, please test the latest version of the app on TestFlight. Please confirm if the issues assigned to @KatieWoe have been fixed or not: https://github.com/phetsims/phet-ios-app/issues/assigned/katiewoe.

@oliver-phet - You should be able to access this version as well if you want to review the latest design implementation.

Assigning @ariel-phet for priority.

@KatieWoe
Copy link
Contributor

KatieWoe commented Nov 7, 2018

@oliver-phet
Copy link
Contributor

There are numerous issues I've seen in (27) so far... filtering isn't working, table/list view don't change the view, filter panel fitting to the device, search/toolbar not hiding on scroll.

@ariel-phet ariel-phet added QA:dev-test Dev test before an RC priority:2-high labels Nov 7, 2018
@ariel-phet ariel-phet removed their assignment Nov 7, 2018
@KatieWoe
Copy link
Contributor

KatieWoe commented Nov 8, 2018

I also notice that https://github.com/phetsims/phet-ios-app/issues/339 occurs here as well as in the published version

@chris-huxtable
Copy link

I just wanted to note that 1.2(27) is still 'alpha' and not feature complete.

Most things in the filter/search area are not complete. I think everything else should be 'beta' status though.

@KatieWoe
Copy link
Contributor

@chris-huxtable I just noticed something, and I'm not sure if it will be fixed when filters are implemented. I'm putting a description here, and will make an issue if you think it is needed. Right now a filter can be added by looking at the info for a sim and selecting one of the subject tags. However, it is not then possible to go back to all the sims.

@chris-huxtable
Copy link

This is already fixed in the feature/tabBar branch and will be included in the next test flight build.

@KatieWoe
Copy link
Contributor

@chris-huxtable I believe that addresses the issues that we needed to check with (27). I'm keeping this open to look for new bugs. Are there any issues that you wanted looked at that were missed or that you want more info/clarification on?

@chris-huxtable
Copy link

I think you have addressed everything. There should be a new version up tomorrow that finally puts a nail in the filters system.

@mattpen
Copy link
Contributor Author

mattpen commented Nov 15, 2018

I've published 1.2(29), should this issue be closed?

@KatieWoe
Copy link
Contributor

I think testing can continue on this issue unless you would like to keep them separate.

@KatieWoe
Copy link
Contributor

Never mind, just saw the new issue. Yes this can be closed.

@mattpen
Copy link
Contributor Author

mattpen commented Nov 15, 2018

New issue for build 29: #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:dev-test Dev test before an RC
Projects
None yet
Development

No branches or pull requests

5 participants