Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC test: Molarity 1.3.0-rc.1 #8

Closed
7 tasks
pixelzoom opened this issue Jun 26, 2017 · 4 comments
Closed
7 tasks

RC test: Molarity 1.3.0-rc.1 #8

pixelzoom opened this issue Jun 26, 2017 · 4 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 26, 2017

RC version:
http://www.colorado.edu/physics/phet/dev/html/molarity/1.3.0-rc.1/molarity_en.html

iFrame test:
http://www.colorado.edu/physics/phet/dev/html/molarity/1.3.0-rc.1/molarity_en-iframe.html

Text matrix:
https://docs.google.com/spreadsheets/d/1tb4vFUYbqCPPIDPOiV6BkamOZiZyWujxaF4al_2q4k4/edit#gid=288440115

In addition to the test matrix, please perform these specific tests on 1 or 2 platforms:

  • stringTest=double (double all strings)
  • stringTest=long (excessively long strings)
  • stringTest=X (short strings)
  • stringTest=rtl (right-to-left text direction)
  • stringTest=xss (test for security issues, passes if it does NOT redirect to another page)
  • full screen test
  • screenshot test

The previous test was 1.3.0-phetiodev.3, see phetsims/tasks#865. There are no issues to verify from that test, and this RC version uses the same shas.

Please mention this issue in any GitHub issues that you create.

@jonathanolson
Copy link
Contributor

It looks like this RC is using SHAs that don't include all of the necessary patches for phetsims/scenery-phet#312, specifically it references phetsims/scenery-phet@db4bf96 in the dependencies.json, which is missing the fix phetsims/scenery-phet@727d5bd.

@pixelzoom, can this be cherry-picked to a "molarity-1.3" branch in scenery-phet, and then have an RC with that fix included?

@phet-steele can you screen other RCs to make sure that they include that commit?

Also, can someone check to see if the following email was received (I sent it out, but saw no replies):
maintenance-email

@ariel-phet, can we come up with a better process than phet-dev emails (if my email sent correctly?)

@pixelzoom
Copy link
Contributor Author

@phet-steele please stop all testing, we're starting over.

@ariel-phet fyi.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jun 27, 2017

@jonathanolson handled cherry-picking the fix to a new molarity-1.3 branch of scenery-phet, while I observed. So I should now be able to proceed with creating 1.3.0-rc.2.

@pixelzoom
Copy link
Contributor Author

Testing continues with 1.3.0-rc.2 in #13.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants