-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression test score displays #817
Comments
List of sims with scores on master:
|
Just an FYI--there is a major known bug in Make a Ten phetsims/make-a-ten#304, but it is still possible to test the score displays. |
I think we can call QA here. |
Thanks @KatieWoe and @Nancy-Salpepi. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For phetsims/vegas#102 I had to make some major changes to the code that displays the users' score in various games. These score displays generally appear on the level selection buttons and/or the status bars in the games. Here are a handful of screenshots that depict score displays in different settings to help clarify:
I'd like to request that the QA team run through the master versions of all sims that have score displays and verify that they look reasonable and match the published versions. I don't think we have a good list, so I think you'll just need to go through the sims and look, or just identify a reasonable subset of sims known to have games and spot check.
Here is an example of a score display that was initially broken by my changes. I have fixed this, but there may be other similar instances. In this case, the color of the score text doesn't match the rest of the test on the status bar.
@KatieWoe and I had a conversation about this, so she is pretty aware of what this is all about, but feel free to ask for any sort of clarification that is needed.
The text was updated successfully, but these errors were encountered: