Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test score displays #817

Closed
2 of 4 tasks
jbphet opened this issue Jun 24, 2022 · 4 comments
Closed
2 of 4 tasks

Regression test score displays #817

jbphet opened this issue Jun 24, 2022 · 4 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Jun 24, 2022

For phetsims/vegas#102 I had to make some major changes to the code that displays the users' score in various games. These score displays generally appear on the level selection buttons and/or the status bars in the games. Here are a handful of screenshots that depict score displays in different settings to help clarify:

image

image

image

I'd like to request that the QA team run through the master versions of all sims that have score displays and verify that they look reasonable and match the published versions. I don't think we have a good list, so I think you'll just need to go through the sims and look, or just identify a reasonable subset of sims known to have games and spot check.

Here is an example of a score display that was initially broken by my changes. I have fixed this, but there may be other similar instances. In this case, the color of the score text doesn't match the rest of the test on the status bar.

image

@KatieWoe and I had a conversation about this, so she is pretty aware of what this is all about, but feel free to ask for any sort of clarification that is needed.

  • Tester = KW, Platform = Win 11 Chrome, Time = 2 hr
  • Tester = NS, Platform = MacOS 12.4 + safari, Time = 5hrs
  • Tester = , Platform = , Time =
  • Tester = , Platform = , Time =
@KatieWoe
Copy link
Contributor

List of sims with scores on master:

  • Area Builder
  • Area Model Algebra
  • Area Model Multiplication
  • Arithmetic
  • Balancing Act
  • Balancing Chemical Equations
  • Build a Fraction
  • Build an Atom
  • Equality Explorer
  • Expression Exchange
  • Fourier Making Waves
  • Fraction Matcher
  • Fractions Equality
  • Fractions Intro
  • Fractions Mixed Numbers
  • Gene Expression Esentials?
  • Graphing Lines
  • Graphing Slope Intercept
  • Make a Ten
  • Number Play
  • Reactants Products and Leftovers

@Nancy-Salpepi
Copy link
Contributor

Just an FYI--there is a major known bug in Make a Ten phetsims/make-a-ten#304, but it is still possible to test the score displays.

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 9, 2022

I think we can call QA here.

@KatieWoe KatieWoe assigned jbphet and unassigned KatieWoe Aug 9, 2022
@jbphet
Copy link
Contributor Author

jbphet commented Aug 9, 2022

Thanks @KatieWoe and @Nancy-Salpepi. Closing.

@jbphet jbphet closed this as completed Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants