Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RichTextIO.textProperty should be phetioState:true by default #1009

Closed
zepumph opened this issue Nov 4, 2019 · 1 comment
Closed

RichTextIO.textProperty should be phetioState:true by default #1009

zepumph opened this issue Nov 4, 2019 · 1 comment
Assignees
@zepumph
Labels
dev:phet-io

Comments

@zepumph
Copy link
Member

zepumph commented Nov 4, 2019 •
edited
Loading

From phetsims/gravity-force-lab#183 and #1008.

This will fix phetsims/gravity-force-lab#183.
@zepumph zepumph self-assigned this Nov 4, 2019
@zepumph zepumph mentioned this issue Nov 4, 2019
Closed
@zepumph zepumph changed the title RichTextIO.textProperty should be phetioState:true by default RichTextIO.textProperty should be phetioState:true by default Nov 4, 2019
zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, phetsims/scenery…
091bba3 
…#1009
zepumph added a commit to phetsims/gravity-force-lab-basics that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, phetsims/scenery…
2ea5756 
…#1009
zepumph added a commit to phetsims/capacitor-lab-basics that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, phetsims/scenery…
1b555e0 
…#1009
zepumph added a commit to phetsims/resistance-in-a-wire that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, phetsims/scenery…
efc7a43 
…#1009
zepumph added a commit to phetsims/graphing-quadratics that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, phetsims/scenery…
f9c9974 
…#1009
zepumph added a commit to phetsims/blackbody-spectrum that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, phetsims/scenery…
6730ba9 
…#1009
zepumph added a commit to phetsims/energy-skate-park that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, phetsims/scenery…
9335136 
…#1009
zepumph added a commit to phetsims/concentration that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, phetsims/scenery…
0b55442 
…#1009
zepumph added a commit to phetsims/beers-law-lab that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, phetsims/scenery…
2d2de60 
…#1009
zepumph added a commit to phetsims/coulombs-law that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, phetsims/scenery…
477dc7e 
…#1009
zepumph added a commit to phetsims/molarity that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, phetsims/scenery…
f6f7ec1 
…#1009
zepumph added a commit that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, #1009
141b983
zepumph added a commit to phetsims/bumper that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, phetsims/scenery…
86a6ea4 
…#1009
zepumph added a commit to phetsims/chains that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, phetsims/scenery…
cfe98df 
…#1009
zepumph added a commit to phetsims/molecules-and-light that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, phetsims/scenery…
7579e0c 
…#1009
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Nov 6, 2019
@zepumph
RichText.textProperty should be stateful by default, phetsims/scenery…
2a83b6d 
…#1009
@zepumph
Copy link
Member Author

zepumph commented Nov 6, 2019

Fixed in the above commit. Just like in NodeIO, this ended up removing this, as the PhetioObject default is phetioState:true. Closing

It will still be good to work on as the most robust solution

@zepumph zepumph closed this as completed Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
dev:phet-io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph