-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper mouse multi-button workarounds #803
Comments
Also, we'd want to have an array of "buttons" pressed on the Mouse, instead of the three options we have now. (buttons being by number). |
Note that this issue is the only thing holding up a new RC (spot check) of RIAW before publication. |
I'm also deprecating Pointer.isDownProperty, it will need more fine-grained control (since that doesn't mention which mouse button is down). |
This might be useful to handle more cleanly in the future, but given the very "edge-case" nature of the bugs reported, not worth putting in any effort at the moment |
This was also noticed in phetsims/balloons-and-static-electricity#91 (comment). |
So phetsims/resistance-in-a-wire#147 brings up an interesting case where we can actually NOT receive a pointerup event for a pointerdown when pressing left/right mouse buttons (probably due to the context menu).
We CAN get the lostpointercapture event (which also triggers after usual ups). So we could theoretically:
Besides being likely to break things:
Luckily we should be able to put a button field on our custom Event type. It turns out I'm the only person who has ever referenced this in code (it's used in canStartPress), so I can localize the changes to Scenery.
Assigning to @ariel-phet for prioritization (as the reward/work ratio for this seems somewhat low).
The text was updated successfully, but these errors were encountered: