Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a low-frequency amplitude modulator #106

Closed
jbphet opened this issue May 18, 2020 · 2 comments
Closed

Add a low-frequency amplitude modulator #106

jbphet opened this issue May 18, 2020 · 2 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented May 18, 2020

In phetsims/wave-interference#497 (comment) the sound design team was discussing using a low-frequency oscillator (LFO) to control the amplitude modulation of a sound (in this case, the sound for a moving speaker that is creating a sound wave). This idea has also come up for modulating the sounds used in the "Proportion and Ratio" simulation. We should have a reusable component that makes it reasonably easy to integrat low-frequency amplitude modulation into our sounds.

@jbphet
Copy link
Contributor Author

jbphet commented May 19, 2020

This is implemented. @samreid - heads up that this exists and can be used for the wave sound in Waves Intro if so desired. You can see a demo of it in action on the 3rd screen of tambo. Feel free to close this issue once you've had a look.

@samreid
Copy link
Member

samreid commented May 21, 2020

Thanks, I tested the demo and will keep this in mind.

@samreid samreid closed this as completed May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants