Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Galaxy S9 (Snapdragon)] Brightness is very low #95

Closed
unazz opened this issue Jun 24, 2018 · 5 comments
Closed

[Galaxy S9 (Snapdragon)] Brightness is very low #95

unazz opened this issue Jun 24, 2018 · 5 comments
Labels
validation pending A potential fix has been commited, this needs to be validated with next release

Comments

@unazz
Copy link

unazz commented Jun 24, 2018

I think it will be fixed by adding "starqlte" (S9) and "star2qlte" (S9+) to this line
https://github.com/phhusson/treble_patches/blob/2acef1db091ca41920a750b14553e38f17532357/patches/platform_frameworks_base/0004-Fix-backlight-control-on-Galaxy-S9.patch#L27

@phhusson
Copy link
Owner

I commited it in
phhusson/platform_frameworks_base@6b3a97f

we'll see

@phhusson phhusson added the validation pending A potential fix has been commited, this needs to be validated with next release label Jun 25, 2018
@unazz
Copy link
Author

unazz commented Jul 5, 2018

I flashed v21 and v22, brightness was working well at first.
However, I flashed stock vendor partition, brightness did not work well.

I checked, ro.vendor.build.fingerprint of Japanese model did not contains "starqlte" / "star2qlte". Instead career's model number was contained.
Probably this is only a Japanese model. I checked other models (Chinese, Latin America, Canada, US, etc) but it does contains "starqlte" / "star2qlte".
Would you please add Japanese model number?
I've sent a PR. (phhusson/platform_frameworks_base#2)

Sorry for my bad English.

@phhusson
Copy link
Owner

Sorry for the very long time to answer.

phhusson/platform_frameworks_base@a770748

Does this good look to you?

@unazz
Copy link
Author

unazz commented Aug 29, 2018

Good fix!

@unazz
Copy link
Author

unazz commented Aug 30, 2018

I flashed AOSP 9.0 v103, brightness is working well.
Thank you very much for the fix!!

@unazz unazz closed this as completed Aug 30, 2018
onde2rock pushed a commit to onde2rock/treble_experimentations that referenced this issue Apr 3, 2022
Add Support To Honor 7A AUM-L29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation pending A potential fix has been commited, this needs to be validated with next release
Projects
None yet
Development

No branches or pull requests

2 participants