Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Support #4

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Add Windows Support #4

merged 3 commits into from
Jan 16, 2023

Conversation

iamfraggle
Copy link

@iamfraggle iamfraggle commented Dec 14, 2022

Some fixes to errors that occur on Windows:

  • Use uri.fsPath instead of uri.path to get the working directory in OS-specific format
  • Escape quote characters inside command strings
  • Use magic text (similar to 'VSCode' pretty format) to represent stash refs so they can be evaluated in a separate step - Windows Command Prompt does not understand $(git ...) expressions and has no equivalent.

@phil294
Copy link
Owner

phil294 commented Dec 14, 2022

wow, that's all it took? amazing!

thanks for tackling this! :-) I will quickly test this out on Linux tomorrow and then make a new release.

I was also thinking of perhaps replacing the ascii graph chars with svg lines (opt-out), but I probably won't include that in the same build.

Copy link
Owner

@phil294 phil294 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small adjustment needed. Could you change that?

web/src/views/MainView.coffee Show resolved Hide resolved
@phil294 phil294 merged commit 2cd756d into phil294:master Jan 16, 2023
@phil294 phil294 mentioned this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants