Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom search engine with custom key binding broken #4340

Closed
smblott-github opened this issue Oct 17, 2023 · 3 comments · Fixed by #4339
Closed

Custom search engine with custom key binding broken #4340

smblott-github opened this issue Oct 17, 2023 · 3 comments · Fixed by #4339

Comments

@smblott-github
Copy link
Collaborator

This might be a duplicate of #4337, but it's not clear.

Describe the bug

I have this custom search engine...

g: http://www.google.com/search?q=%s Google

and this key binding...

map sg Vomnibar.activate keyword=g

... which should open the Vomnibar with the Google custom search engine already activated.

As of the latest update (2.0.3) this no longer works. Basically, the leading g to enable the search engine seems to be dropped.

Note... the search engine does still work if activated manually. So the issue seems to be to do with the Vomnibar activation, not the custom search engine itself.

To Reproduce

Steps to reproduce the behavior:

Add the custom search engine and key mapping above and type sg. We should be dropped into the custom Google search, but you're instead dropped into the generic Vomnibar.

Browser and Vimium version

Chrome: 117.0.5938.157
Vimium: 2.0.3

Thanks for your help.

@NI57721
Copy link
Contributor

NI57721 commented Oct 17, 2023

Thanks for your issue.
This will be fixed by #4339

@mehrad-m
Copy link

Thanks for the fix! Is it possible to show previous search suggestions too? Thanks in advance.

@smblott-github
Copy link
Collaborator Author

Confirm: fixed in 2.0.4.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants