Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready for Review #1

Open
phildini opened this issue Oct 16, 2013 · 1 comment
Open

Ready for Review #1

phildini opened this issue Oct 16, 2013 · 1 comment

Comments

@phildini
Copy link
Owner

/cc @nesquena @timothy1ee

As Tim knows, I've had some major pain issues this week, so my assignment is not up the standard I would normally like.

I think it meets all the criteria, but if there are problems I'm happy to fix them by the end of the week, if you would like me to do so.

thanks.

@timothy1ee
Copy link

I have a very important question for you. The answer to this question was the whole point of the exercise and the thing that tripped many people up. You're reading from self.todos. When are you writing to self.todos? It's very easy to create tables to display stuff, it's tricky to build tables that have controls in them. Please fix and resubmit as soon as you can.

Also, implement the saving/restoring todo items. Use either NSUserDefaults or file I/O, NSArray has a built-in helper to load/save itself to disk. NSUserDefaults is a very commonly used tool, you should practice using it.

The next level is to be able to implement the multi-line to do item. It's an illustration of what it takes to really fine tune a UI. It's an intermediate level task. Not incredibly difficult, but may take you as long as the rest of the assignment.

  • Note: there is a convenient method on NSMutableArray called exchangeObjectAtIndex:withObjectAtIndex:
  • Upon adding a new item, it would be nice to automatically set the focus to the new text field.
  • It's common to dismiss the keyboard on scroll.
  • Good job finding the editButtonItem that automatically tracks the states of the editing state of the UIViewController.

Here's my checklist of things I'm looking at when I'm reviewing this project.

  • Is the Objective-C code styling consistent with standards?
  • Did you create a custom cell or use tableview prototypes? Either approach is fine.
  • In your custom cell, did you configure the Auto Layout properties? Or, if you didn't use AutoLayout, did you set the autoresizingMask to UIViewAutoresizingFlexibleHeight | UIViewAutoresizingFlexibleWidth.
  • How did you sync the UITextField changes with the underlying array of todo items? There are many options:
    • Set the view controller to be the delegate of each UITextField. Track the index of the UITextField using the tag property or objc_getAssociatedObject/objc_setAssociatedObject.
    • Set the cell to be the delegate of the UITextField and create a custom cell delegate.
  • How was persistence implemented?
    • NSUserDefaults
    • File system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants