Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silly britons #2

Closed
wants to merge 5 commits into from
Closed

Conversation

JacoKoster
Copy link
Contributor

Let's fix remove that AM/PM weirdness for normal countries

@JacoKoster
Copy link
Contributor Author

So, i checked the preview and it doesn't detect the zone correctly :-/ What did i do wrong?!

@JacoKoster
Copy link
Contributor Author

So, the worst code in the history of filtering a list, but it works ;-)

@philhawksworth
Copy link
Owner

I like the intent of this, but have an implementation which is a little easier to maintain and for people to parse in future PRs... so I'm treating this as a delightfully detailed feature request, closing this without merging, and I'll push my implementation.

Thanks @JacoKoster

@JacoKoster JacoKoster deleted the silly-britons branch July 20, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants