Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Feasibility of developing a needleman-wunsch global aligner #15

Closed
rhysnewell opened this issue Oct 17, 2022 · 4 comments
Closed

Comments

@rhysnewell
Copy link

Hi Philip,

Just brainstorming here. I wanted to hear your thoughts on the possibility of taking the existing smith-waterman code and altering it to perform a global alignment instead. The only reason I'd want to do this is to see how GKL-rs would compare against currently existing global pairwise aligners, like WFA https://github.com/smarco/WFA2-lib

I'm hoping to take this on as a side project, but I just want to hear if you think GKL-rs is currently adaptable as it currently exists.

Cheers,
Rhys

@philipc
Copy link
Owner

philipc commented Oct 17, 2022

I think it already is global alignment: broadinstitute/gatk#6576 (comment)

But either way, yes I think it is feasible to adapt GKL-rs to handle both.

@rhysnewell
Copy link
Author

Oh easy as, I remember seeing this comment of yours ages ago but must have forgotten about it. Glad to know it's easy, just wanted to double check there wasn't some weirdness happening in the background that would global/local alignments difficult.

Knowing it is already global, i'll go ahead and play around with it. Thanks again!

@philipc
Copy link
Owner

philipc commented Oct 17, 2022

That might have been from #11. So there might still be some overhang differences to account for in order to get the same results as WFA2-lib, but that won't be hard.

@rhysnewell
Copy link
Author

Alright, nice I'll keep you posted then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants