Tests are failing for the master branch

[fehmicansaglam]

[info] *** 7 TESTS FAILED ***
[error] Failed tests:
[error]         com.sksamuel.elastic4s.DeleteTest
[error]         com.sksamuel.elastic4s.CountTest
[error]         com.sksamuel.elastic4s.SearchTest
[error]         com.sksamuel.elastic4s.SearchDslTest
[error] Error during tests:
[error]         com.sksamuel.elastic4s.PercolateTest

[fehmicansaglam]

I have fixed the PercolateTest in 2216f74. But there is a problem with the SyncClient which I couldn't figure out yet causing the DeleteTest fail. And I have no idea about the other failures.

[sksamuel]

I'll get those fixed tonight.

On 3 February 2014 08:32, Fehmi Can Sağlam notifications@github.com wrote:

I have fixed the PercolateTest in 2216f742216f74.
But there is a problem with the SyncClient which I couldn't figure out yet
causing the DeleteTest fail. And I have no idea about the other failures.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/84#issuecomment-33932083
.

[sksamuel]

I've fixed all bar 2 that I've marked as possible bugs in elastic 1.0, and commented them out to get the build green.
It looks like the query builders are never being set on the request in the Elastic Java client for counts and delete by query.

[fehmicansaglam]

I also suspected that but why does it work in async client but not in sync client?

[sksamuel]

We're not testing the same thing in all the clients. We just mix n match.
The request builders don't set the query when you call setQuery on them, so it looks like its a bug in elastic itself. I'll raise it.

[fehmicansaglam]

@sksamuel did you raise those issues? It seems that stable release is due tomorrow.

[sksamuel]

Oh damn no I didn't.
On 11 Feb 2014 11:36, "Fehmi Can Sağlam" notifications@github.com wrote:

@sksamuel https://github.com/sksamuel did you raise those issues? It
seems that stable release is due tomorrow.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/84#issuecomment-34746422
.