two selection bugs

[alpheratz0]

• part of the selection rectangle is not rendered (I think that the problem is here)
• the last item is selected but it should not

A video is worth a thousand images...

selection_bug.mp4

[phillbush]

Hi @alpheratz0

The last two commits fix each bug.

[phillbush]

Btw, I see you're using transparency.
Do the icons and text are transparent as well or only the background?
And how are you achieving transparency?

[alpheratz0]

Btw, I see you're using transparency.
Do the icons and text are transparent as well or only the background?

At first I thought it was only the background, but by setting the opacity to a lower
value you can see that also the icons and text gets transparent.

And how are you achieving transparency?

Picom, why?

[phillbush]

That's because XFiles uses the default X depth and X drawing routines, which does not use alpha channel.
I'm working on a new commit that makes transparency work only on the background.

[phillbush]

Ok, I added a XFiles.opacity X resource.
It is a float number from 0.0 (full transparent) to 1.0 (full opaque).

It required considerable changing on the X drawing code... I hope I have not broken anything...

[phillbush]

It still needs a compositor for the transparency to work, but you now need to configure the opacity in XFiles itself (via X resources) rather than on picom.