Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the multi-apps explainer #2

Closed
michaelwasserman opened this issue Feb 11, 2021 · 3 comments
Closed

Consider the multi-apps explainer #2

michaelwasserman opened this issue Feb 11, 2021 · 3 comments

Comments

@michaelwasserman
Copy link

Please consider the multi-apps explainer:
https://github.com/ivansandrk/multi-apps/blob/main/explainer.md

Perhaps multi-apps would want multiple ids? Perhaps some id schemas would at least make that possible in the future?
I'm not super familiar here, I'm mainly hoping that we'd get a broad view of what might be needed around each proposal.

@philloooo
Copy link
Owner

thanks, I took a look at that explainer, seem to make more sense to me to have one id for the multi-apps case, as there will be one manifest for a multi-apps PWA, thus the installation and update life cycle will treat it as one entity. We can continue the conversation on the issue you created there.

@michaelwasserman
Copy link
Author

Acknowledged; sgtm. Feel free to reopen this issue as needed.

@dmurph
Copy link

dmurph commented Feb 17, 2021

FYI - I believe the current preferred solution is to not have one manifest and instead have one manifest per app, which would let us use all of our existing updating logic.

In my head I was imagining:

  • Sub apps will never be their own app (like, never independent of parent app, so we don't need to support migration to something like that),
  • We allow an app, in our database proto, to reference sub-app ids. (I guess maybe in sync data too)
  • Those sub-apps basically exist in our system as regular apps, but we store the parent id in the web app database proto (and in the sync data)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants