move wipe_disk() from fs/btrfs to system/osi rockstor#1320

Not directly related to btrfs so moving to more general location.
Added docstrings and did minor variable name refactoring.

src/rockstor/fs/btrfs.py

@@ -45,7 +45,6 @@
 DD = '/bin/dd'
 DEFAULT_MNT_DIR = '/mnt2/'
 RMDIR = '/bin/rmdir'
-WIPEFS = '/usr/sbin/wipefs'
 QID = '2015'
 
 
@@ -1103,12 +1102,6 @@ def scan_disks(min_size):
     return disks
 
 
-def wipe_disk(disk):
-    # todo candidate for move to system/osi as not btrfs related
-    disk = ('/dev/disk/by-id/%s' % disk)
-    return run_command([WIPEFS, '-a', disk])
-
-
 def blink_disk(disk, total_exec, read, sleep):
     # todo candidate for move to system/osi as not btrfs related
     DD_CMD = [DD, 'if=/dev/disk/by-id/%s' % disk, 'of=/dev/null', 'bs=512',

src/rockstor/storageadmin/views/disk.py

@@ -21,7 +21,7 @@
 from rest_framework.response import Response
 from django.db import transaction
 from storageadmin.models import (Disk, Pool, Share)
-from fs.btrfs import (scan_disks, wipe_disk, blink_disk, enable_quota,
+from fs.btrfs import (scan_disks, blink_disk, enable_quota,
                       btrfs_uuid, pool_usage, mount_root, get_pool_info,
                       pool_raid, enable_quota)
 from storageadmin.serializers import DiskInfoSerializer
@@ -31,7 +31,7 @@
 import rest_framework_custom as rfc
 from system import smart
 from system.osi import set_disk_spindown, enter_standby, get_dev_byid_name, \
-    get_devname
+    wipe_disk
 from copy import deepcopy
 import uuid
 import json

src/rockstor/storageadmin/views/disk_smart.py

@@ -27,7 +27,7 @@
                                  SMARTCapability, SMARTErrorLog,
                                  SMARTErrorLogSummary, SMARTTestLog,
                                  SMARTTestLogDetail, SMARTIdentity)
-from fs.btrfs import (scan_disks, wipe_disk, blink_disk, btrfs_uuid,
+from fs.btrfs import (scan_disks, blink_disk, btrfs_uuid,
                       pool_usage, mount_root)
 from storageadmin.serializers import SMARTInfoSerializer
 from storageadmin.util import handle_exception

src/rockstor/system/osi.py

@@ -53,6 +53,7 @@
 LSBLK = '/usr/bin/lsblk'
 HDPARM = '/usr/sbin/hdparm'
 SYSTEMCTL_BIN = '/usr/bin/systemctl'
+WIPEFS = '/usr/sbin/wipefs'
 
 
 def inplace_replace(of, nf, regex, nl):
@@ -388,6 +389,17 @@ def remount(mnt_pt, mnt_options):
     return True
 
 
+def wipe_disk(disk_byid):
+    """
+    Simple run_command wrapper to execute "wipefs -a disk_byid"
+    :param disk_byid: by-id type name without path as found in db Disks.name.
+    :return: o, e, rc tuple returned by the run_command wrapper running the
+    locally generated wipefs command.
+    """
+    disk_byid_withpath = ('/dev/disk/by-id/%s' % disk_byid)
+    return run_command([WIPEFS, '-a', disk_byid_withpath])
+
+
 def convert_to_kib(size):
     """
     Attempts to convert a size string that is initially expected to have 3