Limit lifetime of cloned objects

[tathanhdinh]

Hello all,

There are some cloned objects which may not need to live as long as cloning object, for example:

glide/src/ui_context.rs

Lines 50 to 54 in c019573

	let pause_button = gtk::Button::new();
	let pause_actionable = pause_button.clone().upcast::<gtk::Actionable>();
	pause_actionable.set_action_name("app.pause");

can be rewritten as:

let pause_button = {
  let button = gtk::Button::new();
  button.clone().upcast::<gtk::Actionable>().set_action_name("app.pause");
  button
};

...cloned pause_button needn't to live here..

It's just a master of taste, and it does not contribute anything new so feel free to reject if you don't like.

Many thanks for any comment.

[philn]

Oh nice, a builder file :) It doesn't seem to be used though?

[tathanhdinh]

@philn Sorry, sorry, this UI file is not used yet. It should not be included in the PR.
I'm push it by chance just hours ago, it's rather a WIP where I try to use GtkBuilder to separate UI from code of glide.
I will move this file into another branch.