Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seperated UI #17

Closed
tathanhdinh opened this issue Oct 9, 2018 · 4 comments
Closed

Seperated UI #17

tathanhdinh opened this issue Oct 9, 2018 · 4 comments

Comments

@tathanhdinh
Copy link
Contributor

Hi @philn
As we've discussed brieftly in #16, could you please take a look at this branch where I'm trying to separate UI design from the code.

The work is not ready yet, it's rather a WIP to get your feedback.

Many thanks for any comment.
@philn
Copy link
Owner

philn commented Oct 9, 2018

Looks like a good start! The only issue I noticed so far is that the fullscreen button doesn't have the right picture.

@philn
Copy link
Owner

philn commented Oct 30, 2018

As a heads-up, I will most likely try to make the GTK UI optional, at least on macOS, where GTK support is really bad... There I will provide some cocoa/whatever UI, I think...

@philn
Copy link
Owner

philn commented Dec 23, 2018

WIP over at https://github.com/philn/glide/tree/separated-ui
No idea why though, actions set on widget have no effect... Any help is welcome :)

@philn
Copy link
Owner

philn commented Dec 24, 2018

Ok that's a bug in the Homebrew gtk+3 package, Homebrew/homebrew-core#35412
Next steps would be to move the about dialog and menus out of the code. I'll get started.

@philn philn closed this as completed in 32cf04f Dec 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philn @tathanhdinh