Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imago doesn't understand that docker.io/owner/repo is the same as owner/repo #37

Closed
haslersn opened this issue Nov 28, 2022 · 1 comment · Fixed by #38
Closed

imago doesn't understand that docker.io/owner/repo is the same as owner/repo #37

haslersn opened this issue Nov 28, 2022 · 1 comment · Fixed by #38
Labels
bug Something isn't working

Comments

@haslersn
Copy link
Contributor

In the container runtime we use, owner/repo is a synonym for docker.io/owner/repo. However, imago doesn't understand that:

2022/11/28 04:00:09     element on element-674f8b8bd4-rfh8w need to be updated from docker.io/vectorim/element-web@sha256:aecc84718746ac455556dcb60a3ad0674c44792bd9e472cd5886da1b0afe6bd3 to vectorim/element-web@sha256:aecc84718746ac455556dcb60a3ad0674c44792bd9e472cd5886da1b0afe6bd3

Likewise, repo is a synonym for docker.io/library/repo. imago doesn't understand that either:

2022/11/28 04:00:08     metrics-proxy on pretix-54f4c584df-bxt2f need to be updated from docker.io/library/nginx@sha256:e209ac2f37c70c1e0e9873a5f7231e91dcd83fdf1178d8ed36c2ec09974210ba to nginx@sha256:e209ac2f37c70c1e0e9873a5f7231e91dcd83fdf1178d8ed36c2ec09974210ba

Wouldn't it be sufficient for imago to check the SHA-256 hash? After all, we don't care how the image is named, if the content is correct.

@philpep philpep added the bug Something isn't working label Nov 29, 2022
@philpep
Copy link
Owner

philpep commented Nov 29, 2022

Right, I think sha256 is enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants