[WIP][waiting-feedback] Add GitLab support. #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this I can do:
If you think I'm going in the right direction I will continue to implement as much of GitLab as possible in this manner, and add tests.
The goal is to:
/repos/:user/:name
becomes GitLab/projects/#{user}%2F#{repo}
.path
reply field becomes is converted to it's GitHub analogue.name
, and.name
which is the humanish name is converted to a new identifierhumanName
.This is simplistic, but works for many fields.
I felt that implementing it here was simpler than at https://github.com/philschatz/octokat.js because in my mind this is a perfect case for using inheritance to model the situation, and Octokat has no explicit methods that can be polymorphed.