Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print the percent sign optionally in format.pct #40

Closed
philsf opened this issue Aug 27, 2018 · 2 comments · Fixed by #43
Closed

Print the percent sign optionally in format.pct #40

philsf opened this issue Aug 27, 2018 · 2 comments · Fixed by #43
Labels
API API changes feature
Milestone
v0.6.1

Comments

@philsf
Copy link
Owner

philsf commented Aug 27, 2018

Not every situation we are interested in printing perecentages with the percent sign.

This should be an optional (logical) argument. In fact, the default should be FALSE.
@philsf philsf added the feature label Aug 27, 2018
@philsf philsf added this to the v0.6.1 milestone Aug 27, 2018
@philsf
Copy link
Owner Author

philsf commented Oct 5, 2018

The argument was implemented in commit e909823, released inv0.6.0.

The only change left is the default FALSE.

@philsf philsf mentioned this issue Oct 5, 2018
Merged
@philsf philsf closed this as completed in #43 Oct 5, 2018
@philsf philsf mentioned this issue Oct 5, 2018
Closed
@philsf philsf added the API API changes label Oct 22, 2018
@philsf
Copy link
Owner Author

philsf commented Oct 22, 2018 •
edited
Loading

The default to FALSE was really an unnecessary and dumb API change (see #49). Label aded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API API changes feature
Projects
None yet
Milestone
v0.6.1
Development

Successfully merging a pull request may close this issue.

change default argument pct.symbol to FALSE philsf/philsfmisc
1 participant
@philsf