Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for 'HTTP/1.1 302 Found' #2329

Merged
merged 1 commit into from
Jan 18, 2014
Merged

Conversation

karbassi
Copy link
Contributor

@karbassi karbassi commented Jan 6, 2014

Before:

$ brew cask checklinks cloud-pull 
link check result for cloud-pull: failed
 - unexpected http response, expecting "HTTP/1.0 200 OK" or "HTTP/1.1 200 OK", got "HTTP/1.1 302 Found"

After:

$ brew cask checklinks cloud-pull 
link check result for cloud-pull: passed

@phinze
Copy link
Contributor

phinze commented Jan 18, 2014

I suppose some app distributors would like the flexibility of being able to provide a stable URL that redirects for mirrors support and stuff like that. Ideally we'd follow the redirect when checking links, but for I'm okay with this as an initial solution.

phinze added a commit that referenced this pull request Jan 18, 2014
Added check for 'HTTP/1.1 302 Found'
@phinze phinze merged commit 9ab582e into Homebrew:master Jan 18, 2014
@karbassi karbassi deleted the checklinks branch January 28, 2014 15:36
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants