Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete List of Symbols #74

Closed
StockTrackerJ opened this issue Dec 29, 2019 · 4 comments
Closed

Incomplete List of Symbols #74

StockTrackerJ opened this issue Dec 29, 2019 · 4 comments
Labels

Comments

@StockTrackerJ
Copy link

StockTrackerJ commented Dec 29, 2019

Hi Edge,

I check the "all stock" and individual stock there are missing symbols/stock codes. There about 60-90 missing stocks. Sample here is LBC and FEU. Can you pls. confirm if this is the case? Thanks.

image
image

@edgedalmacio
Copy link
Collaborator

edgedalmacio commented Jan 2, 2020

There are cases when some stocks do not trade for a day or several days. When that happens, the API will return a 404 for the stocks not trading on that day.

Example:

http://phisix-api3.appspot.com/stocks/LBC.2019-12-30.json

  • LBC wasn't trading on Dec 30, 2019, that's why you were getting a 404 response.

http://phisix-api3.appspot.com/stocks/LBC.2019-01-02.json

  • However, if you check LBC for Jan 2, 2020, you would see that it's working as expected.

@StockTrackerJ
Copy link
Author

StockTrackerJ commented Jan 7, 2020

HI Edge,

Thanks for the clarification. Is it to possible to make it still return the last traded price even for days without a trade? Example, let's say Stock A was traded last Jan 2 with price of P10 with volume of 100K, then no trades on succeeding days, let's say Jan 8 (Trading day), it has no trade but when requested (on said date), will still return a price of P10 with % change of 0 and volume of 0, instead of getting 404 response. Is that possible? Thanks very much for your work. Appreciate it a lot.

@alexroldan
Copy link

I agree with you ... it is better to return the last data instead of removing it from the arrays ...

@stale
Copy link

stale bot commented Jul 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 21, 2020
@stale stale bot closed this as completed Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants