Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add on_mount option to live_session #1515

Merged
merged 9 commits into from
Jul 2, 2021
Merged

Add on_mount option to live_session #1515

merged 9 commits into from
Jul 2, 2021

Conversation

mcrumm
Copy link
Member

@mcrumm mcrumm commented Jul 2, 2021

Follows #1490 and #1511 to allow on_mount at the router via live_session.

@mcrumm mcrumm marked this pull request as ready for review July 2, 2021 15:50
@mcrumm mcrumm requested a review from chrismccord July 2, 2021 15:58
@mcrumm mcrumm merged commit 3d1eb67 into master Jul 2, 2021
@mcrumm mcrumm deleted the mc-live-session-on-mount branch July 2, 2021 16:31
@nicklayb
Copy link

nicklayb commented Aug 27, 2021 •
edited
Loading

In tests, does the live/2 helper calls the hooks in the :on_mount option of a live_session/3? I can't find anything regarding the testability of hooks of a live_session in the docs but I might have just missed it.

@josevalim
Copy link
Member

Yes, if you are doing live("/foo", ...), the on_mount callbacks should be invoked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

@chrismccord chrismccord Awaiting requested review from chrismccord

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcrumm @nicklayb @josevalim