Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sidebar icon doesn't refresh after being changed #65

Closed
jmshgs opened this issue Oct 5, 2023 · 5 comments
Closed

sidebar icon doesn't refresh after being changed #65

jmshgs opened this issue Oct 5, 2023 · 5 comments

Comments

@jmshgs
Copy link
Member

jmshgs commented Oct 5, 2023

this might only be on my igdb branch, but honestly not sure
@Shock9616
Copy link
Member

That does appear to be the case. The icon refreshes just fine on the latest release

@jmshgs
Copy link
Member Author

jmshgs commented Oct 11, 2023

ideas to debug:

  • check whether the icon is refreshed when the game is saved or when the icon is inputted to test whether it's updating in the save or the import method

@jmshgs
Copy link
Member Author

jmshgs commented Oct 12, 2023

tested the latest release (v0.0.8) on a school computer lol
the icon is refreshed upon being imported, meaning it doesn't have to do with the saving of games but rather the caching on images.
the header is also refreshed when the image is imported. the issue must've come when I refactored the image saving methods in ImageUtils.swift.

@jmshgs jmshgs mentioned this issue Oct 12, 2023
Closed
@jmshgs
Copy link
Member Author

jmshgs commented Oct 26, 2023

done in igdb

@jmshgs
Copy link
Member Author

jmshgs commented Nov 11, 2023

merged in #76

@jmshgs jmshgs closed this as completed Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Shock9616 @jmshgs