Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Enable long-touch menu in photo viewer on iOS #1233

Closed
jkgeyti opened this issue Apr 26, 2021 · 10 comments
Closed

UX: Enable long-touch menu in photo viewer on iOS #1233

jkgeyti opened this issue Apr 26, 2021 · 10 comments
Assignees
Labels
mobile Especially important for mobile devices released Available in the stable release ux Impacts User Experience

Comments

@jkgeyti
Copy link

jkgeyti commented Apr 26, 2021

With the recent release, and the improved touch support, photoprism is finally usable on iOS! Loving all the good work and fantastic additions 🎉 There's still a handful of issues wrt downloading and sharing, but in the interim, it'd be good to be able to copy the JPEG shown in the photo viewer, so images can be quickly shared with other apps.

In desktop browsers, you can right click images to get a context menu that includes a "Copy image" context menu, but on iOS, -webkit-touch-callout: none is set on images shown in the popup full-screen image viewer, which disables the long-press context menu.

As a quick hack, adding the following css and long-clicking images produces the context menu shown in the screenshot below. I'm not sure if there's any good justification for disabling the context menu on mobile devices, but if not, it'd be really convenient if it could be enabled 🙏 .

.pswp__img {
    -webkit-touch-callout: default !important;
}

@photoprism photoprism deleted a comment from vader355 Apr 27, 2021
@graciousgrey
Copy link
Member

We use photoswipe for the fullscreen viewer, so we did not implement it on our own. There might be a reason why it is implemented this way. Changing this would require testing on all kinds of devices and browsers which we cannot afford at the moment. Opening images in other apps is planned see: #25 or #658

@jkgeyti
Copy link
Author

jkgeyti commented Apr 28, 2021

Makes sense. I've raised it as a request on the photoswipe repo.

@jkgeyti
Copy link
Author

jkgeyti commented Apr 29, 2021

This is targeted to be solved in photoswipe v5 (unreleased)

dimsemenov/PhotoSwipe#1748 (comment)

@Soulplayer
Copy link

I see that version 5 is released yet it does not work on photoprism. This would be a great addition 😇?

lastzero added a commit that referenced this issue Feb 13, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero changed the title Enable image viewer long-press context menu on iOS Safari UX: Enable long-touch menu in photo viewer on iOS Feb 13, 2023
@lastzero lastzero self-assigned this Feb 13, 2023
@lastzero lastzero added the ux Impacts User Experience label Feb 13, 2023
@lastzero lastzero reopened this Feb 13, 2023
@lastzero lastzero added the please-test Ready for acceptance test label Feb 13, 2023
@lastzero
Copy link
Member

After testing it locally, I added this bit of CSS as a workaround until we have a new viewer. It's available for testing in our development preview and demo in about one hour.

@lastzero lastzero added the mobile Especially important for mobile devices label Feb 13, 2023
@lastzero
Copy link
Member

Note that this COULD confuse some users, since the menu refers to the image displayed in the viewer. However, this is only a thumbnail without metadata, not the original file.

@Soulplayer
Copy link

Okay it’s better then nothing. Thanks! I will subscribe today to support the project

lastzero added a commit that referenced this issue Feb 27, 2023
Signed-off-by: Michael Mayer <michael@liquidbytes.net>
seeschloss pushed a commit to seeschloss/photoprism that referenced this issue Apr 10, 2023
Signed-off-by: Michael Mayer <michael@liquidbytes.net>
@graciousgrey graciousgrey added tested Changes have been tested successfully and removed please-test Ready for acceptance test labels Apr 24, 2023
@Soulplayer
Copy link

Soulplayer commented May 2, 2023

Just want to let you know it works in safari on iOS but in the PWA version not.

@lastzero
Copy link
Member

lastzero commented May 3, 2023

I remember that we discovered problems with the menu, eg after updating to a new iOS version. That was a while ago and I'm not using iOS very often (just on the iPad), so unfortunately, I don't remember any details.

@graciousgrey graciousgrey added released Available in the stable release and removed tested Changes have been tested successfully labels May 3, 2023
@graciousgrey
Copy link
Member

I created a follow up issue for this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Especially important for mobile devices released Available in the stable release ux Impacts User Experience
Projects
Status: Release 🌈
Development

No branches or pull requests

4 participants