-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Enable long-touch menu in photo viewer on iOS #1233
Comments
We use photoswipe for the fullscreen viewer, so we did not implement it on our own. There might be a reason why it is implemented this way. Changing this would require testing on all kinds of devices and browsers which we cannot afford at the moment. Opening images in other apps is planned see: #25 or #658 |
Makes sense. I've raised it as a request on the photoswipe repo. |
This is targeted to be solved in photoswipe v5 (unreleased) |
I see that version 5 is released yet it does not work on photoprism. This would be a great addition 😇? |
Signed-off-by: Michael Mayer <michael@photoprism.app>
After testing it locally, I added this bit of CSS as a workaround until we have a new viewer. It's available for testing in our development preview and demo in about one hour. |
Note that this COULD confuse some users, since the menu refers to the image displayed in the viewer. However, this is only a thumbnail without metadata, not the original file. |
Okay it’s better then nothing. Thanks! I will subscribe today to support the project |
Signed-off-by: Michael Mayer <michael@liquidbytes.net>
Signed-off-by: Michael Mayer <michael@liquidbytes.net>
Just want to let you know it works in safari on iOS but in the PWA version not. |
I remember that we discovered problems with the menu, eg after updating to a new iOS version. That was a while ago and I'm not using iOS very often (just on the iPad), so unfortunately, I don't remember any details. |
I created a follow up issue for this: |
With the recent release, and the improved touch support, photoprism is finally usable on iOS! Loving all the good work and fantastic additions 🎉 There's still a handful of issues wrt downloading and sharing, but in the interim, it'd be good to be able to copy the JPEG shown in the photo viewer, so images can be quickly shared with other apps.
In desktop browsers, you can right click images to get a context menu that includes a "Copy image" context menu, but on iOS,
-webkit-touch-callout: none
is set on images shown in the popup full-screen image viewer, which disables the long-press context menu.As a quick hack, adding the following css and long-clicking images produces the context menu shown in the screenshot below. I'm not sure if there's any good justification for disabling the context menu on mobile devices, but if not, it'd be really convenient if it could be enabled 🙏 .
The text was updated successfully, but these errors were encountered: