Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos: Skip related images when downloading #1436

Closed
tanuva opened this issue Jul 16, 2021 · 11 comments
Closed

Videos: Skip related images when downloading #1436

tanuva opened this issue Jul 16, 2021 · 11 comments
Assignees
Labels
bug Something isn't working released Available in the stable release

Comments

@tanuva
Copy link

tanuva commented Jul 16, 2021

G'day,

I recently tried to download a video from PhotoPrism (PWA on iOS). What I'm offered looks like the video thumbnail image though, with a file name pattern like video_name.mp4.jpg. I suspect this is not intentional? :)

Observed on my local installation as well as the PP demo setup.

@lastzero
Copy link
Member

Downloads both for me, at least on a desktop browser?

downloads
download-1

@graciousgrey graciousgrey added the bug Something isn't working label Jul 16, 2021
@graciousgrey
Copy link
Member

Thanks for reporting! I can reproduce it with the PWA on iOS.

@tanuva As a workaround for now you can open the edit dialogue of the video and click the download button for the mp4 file within the files section (https://docs.photoprism.org/user-guide/organize/edit/#edit-files)

@tanuva
Copy link
Author

tanuva commented Jul 16, 2021

Thanks, the workaround... works. :)

I must admit though I find that "multiple files downloaded at once" behaviour a bit unexpected. For stacked photos it probably makes sense. With video preview images it feels more like I get internal helper files thrown at me. 🤔

@graciousgrey graciousgrey changed the title PP offers video thumbnail image when attempting to download a video PWA on iOS offers video thumbnail image when attempting to download a video Jul 16, 2021
@lastzero
Copy link
Member

Yes, for videos it probably doesn't make much sense for most users - unless your OS shows no native preview or you need a still picture as preview e.g. when sharing on social media. For RAWs, it often makes sense as browsing through those directly is typically super slow and they're not good for sharing as well.

@graciousgrey
Copy link
Member

Maybe we should change the default behaviour vor videos until we come to this ticket: #449.

@lastzero
Copy link
Member

Should also never download a transcoded MP4 / AVC version, always just the original even when stacked with other files?

@tanuva
Copy link
Author

tanuva commented Jul 16, 2021

That one left me thinking for a bit. When downloading videos to a, say, restricted device such as a phone or tablet I would obviously prefer a transcoded video that plays over an original that doesn‘t.

Then again, on a proper computer I‘d of course want the original. Maybe have options on large screens and offer compatible video by default on smaller ones? Then there‘s edge cases again. Phew.

@lastzero lastzero changed the title PWA on iOS offers video thumbnail image when attempting to download a video Videos: Skip related images when downloading Jul 16, 2021
@lastzero
Copy link
Member

Started a new preview build for testing: https://drone.photoprism.app/photoprism/photoprism/1500

Unsure how to handle live photos as some people may want to download the still picture along with the video file. Sometimes it's all in one file and the still picture was extracted, or it was automatically created by PhotoPrism. Probably need to handle those cases differently.

@lastzero lastzero added the please-test Ready for acceptance test label Jul 16, 2021
@lastzero lastzero self-assigned this Jul 16, 2021
@tanuva
Copy link
Author

tanuva commented Jul 17, 2021

Works fine in the preview build, thanks for the quick fix! \o/

@lastzero
Copy link
Member

Thanks for reporting & testing! Had it in the back of my mind for a while... ultimately need to add settings for this.

@lastzero
Copy link
Member

Downloading multiple files via iOS PWA still is broken? You're welcome to create a new issue for this... maybe a contributor can figure out how to fix it as it seems to work on all other devices and operating systems... wonder why Apple is so special.

@graciousgrey graciousgrey added released Available in the stable release and removed please-test Ready for acceptance test labels Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

3 participants