-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Videos: Skip related images when downloading #1436
Comments
Thanks for reporting! I can reproduce it with the PWA on iOS. @tanuva As a workaround for now you can open the edit dialogue of the video and click the download button for the mp4 file within the files section (https://docs.photoprism.org/user-guide/organize/edit/#edit-files) |
Thanks, the workaround... works. :) I must admit though I find that "multiple files downloaded at once" behaviour a bit unexpected. For stacked photos it probably makes sense. With video preview images it feels more like I get internal helper files thrown at me. 🤔 |
Yes, for videos it probably doesn't make much sense for most users - unless your OS shows no native preview or you need a still picture as preview e.g. when sharing on social media. For RAWs, it often makes sense as browsing through those directly is typically super slow and they're not good for sharing as well. |
Maybe we should change the default behaviour vor videos until we come to this ticket: #449. |
Should also never download a transcoded MP4 / AVC version, always just the original even when stacked with other files? |
That one left me thinking for a bit. When downloading videos to a, say, restricted device such as a phone or tablet I would obviously prefer a transcoded video that plays over an original that doesn‘t. Then again, on a proper computer I‘d of course want the original. Maybe have options on large screens and offer compatible video by default on smaller ones? Then there‘s edge cases again. Phew. |
Started a new preview build for testing: https://drone.photoprism.app/photoprism/photoprism/1500 Unsure how to handle live photos as some people may want to download the still picture along with the video file. Sometimes it's all in one file and the still picture was extracted, or it was automatically created by PhotoPrism. Probably need to handle those cases differently. |
Works fine in the preview build, thanks for the quick fix! \o/ |
Thanks for reporting & testing! Had it in the back of my mind for a while... ultimately need to add settings for this. |
Downloading multiple files via iOS PWA still is broken? You're welcome to create a new issue for this... maybe a contributor can figure out how to fix it as it seems to work on all other devices and operating systems... wonder why Apple is so special. |
G'day,
I recently tried to download a video from PhotoPrism (PWA on iOS). What I'm offered looks like the video thumbnail image though, with a file name pattern like
video_name.mp4.jpg
. I suspect this is not intentional? :)Observed on my local installation as well as the PP demo setup.
The text was updated successfully, but these errors were encountered: